From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3F29521D046A5 for ; Mon, 18 Sep 2017 08:21:29 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 08:24:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,413,1500966000"; d="scan'208";a="129849033" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 18 Sep 2017 08:24:31 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.182]) by FMSMSX105.amr.corp.intel.com ([169.254.4.92]) with mapi id 14.03.0319.002; Mon, 18 Sep 2017 08:24:26 -0700 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" CC: "Li, Huajing" Thread-Topic: [PATCH] ShellPkg/dmpstore: Show name of known variable vendor GUID Thread-Index: AQHTMEldxishgmqjEkuPPVc5YwWYy6K6w8Bw Date: Mon, 18 Sep 2017 15:24:25 +0000 Message-ID: References: <20170918064227.295020-1-ruiyu.ni@intel.com> In-Reply-To: <20170918064227.295020-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTRmOTI0ZGMtZGQ3OS00NzE4LWEyYWQtZjg4ZGUxYzc3YjRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikk2RmFIRTZpcU5HNzJYY2NENG80Z3c4aWViUkpZb3Jla1ZCWlQxdUw1Nlk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/dmpstore: Show name of known variable vendor GUID X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 15:21:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Whats the difference between HEADER_LINE and HEADER_LINE2? They look the s= ame to me... > -----Original Message----- > From: Ni, Ruiyu > Sent: Sunday, September 17, 2017 11:42 PM > To: edk2-devel@lists.01.org > Cc: Li, Huajing ; Carsey, Jaben > > Subject: [PATCH] ShellPkg/dmpstore: Show name of known variable vendor > GUID > Importance: High >=20 > From: Huajing Li >=20 > Change "dmpstore" to show name of known variable vendor GUID. > The name is got from ShellProtocol.GetGuidName(). >=20 > Cc: Jaben Carsey > Reviewed-by: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Huajing Li > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 17 > +++++++++++++---- > .../UefiShellDebug1CommandsLib.uni | 1 + > 2 files changed, 14 insertions(+), 4 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > index aeffc89b19..062ab5dc3a 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > @@ -424,6 +424,7 @@ CascadeProcessVariables ( > CHAR16 *AttrString; > CHAR16 *HexString; > EFI_STATUS SetStatus; > + CHAR16 *GuidName; >=20 > if (ShellGetExecutionBreakFlag()) { > return (SHELL_ABORTED); > @@ -521,10 +522,18 @@ CascadeProcessVariables ( > Status =3D EFI_OUT_OF_RESOURCES; > } > } else { > - ShellPrintHiiEx ( > - -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE), > gShellDebug1HiiHandle, > - AttrString, &FoundVarGuid, FoundVarName, DataSize > - ); > + Status =3D gEfiShellProtocol->GetGuidName(&FoundVarGuid, > &GuidName); > + if (EFI_ERROR (Status)) { > + ShellPrintHiiEx ( > + -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE), > gShellDebug1HiiHandle, > + AttrString, &FoundVarGuid, FoundVarName, DataSize > + ); > + } else { > + ShellPrintHiiEx ( > + -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE2), > gShellDebug1HiiHandle, > + AttrString, GuidName, FoundVarName, DataSize > + ); > + } > DumpHex (2, 0, DataSize, DataBuffer); > } > SHELL_FREE_NON_NULL (AttrString); > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > index f733a67f0b..b6a133a454 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman > dsLib.uni > @@ -385,6 +385,7 @@ > #string STR_DMPSTORE_LOAD_GEN_FAIL #language en-US "%H%s%N: > Failed to set variable %H%s%N: %r.\r\n" > #string STR_DMPSTORE_LOAD_BAD_FILE #language en-US "%H%s%N: > Incorrect file format.\r\n" > #string STR_DMPSTORE_HEADER_LINE #language en-US "Variable > %H%s%N '%H%g%N:%H%s%N' DataSize =3D 0x%02x\r\n" > +#string STR_DMPSTORE_HEADER_LINE2 #language en-US "Variable > %H%s%N '%H%s%N:%H%s%N' DataSize =3D 0x%02x\r\n" > #string STR_DMPSTORE_DELETE_LINE #language en-US "Delete variable > '%H%g%N:%H%s%N': %r\r\n" > #string STR_DMPSTORE_NO_VAR_FOUND #language en-US "%H%s%N: > No matching variables found.\r\n" > #string STR_DMPSTORE_NO_VAR_FOUND_SFO #language en-US > "VariableInfo,\"\",\"\",\"\",\"\",\"\"\r\n" > -- > 2.12.2.windows.2