From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 37B6121E43B6C for ; Fri, 22 Sep 2017 06:57:32 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Sep 2017 07:00:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,427,1500966000"; d="scan'208";a="1197976117" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 22 Sep 2017 07:00:36 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 22 Sep 2017 07:00:36 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.182]) by FMSMSX151.amr.corp.intel.com ([169.254.7.169]) with mapi id 14.03.0319.002; Fri, 22 Sep 2017 07:00:29 -0700 From: "Carsey, Jaben" To: Ard Biesheuvel , Laszlo Ersek CC: "edk2-devel@lists.01.org" , "Ni, Ruiyu" , "Shi, Steven" Thread-Topic: [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure Thread-Index: AQHTM6ecRvDlzQtayEKrzlsjO35oRaLBX8SA//+PMQA= Date: Fri, 22 Sep 2017 14:00:29 +0000 Message-ID: References: <20170922133456.8910-1-lersek@redhat.com> <49664C7F-F0AA-46AF-84A2-05F322BDB053@linaro.org> In-Reply-To: <49664C7F-F0AA-46AF-84A2-05F322BDB053@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTNhMTIwM2MtYjc5Yy00MDVhLWJjZGMtMTYxZGNiMTk1ZmU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlwvUUhtOUJnRU9aWGRtNkdcLytBYkkyWFNNUlUwN2V6eFlSa0Nrd1Nja04yOD0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 13:57:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Friday, September 22, 2017 6:44 AM > To: Laszlo Ersek > Cc: edk2-devel@lists.01.org; Carsey, Jaben ; Ni, > Ruiyu ; Shi, Steven > Subject: Re: [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure > Importance: High >=20 >=20 >=20 > On 22 Sep 2017, at 06:34, Laszlo Ersek wrote: >=20 > >> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: > error: > >> passing argument 2 of 'gEfiShellProtocol->GetGuidName' from > incompatible > >> pointer type [-Werror=3Dincompatible-pointer-types] > >> > >> Status =3D gEfiShellProtocol->GetGuidName(&FoundVarGuid, > &GuidName); > >> ^ > >> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: > note: > >> expected 'const CHAR16 ** {aka const short unsigned int **}' but > >> argument is of type 'CHAR16 ** {aka short unsigned int **}' > > > > Pointer-to-(pointer-to-CHAR16) and pointer-to-(pointer-to-const-CHAR16) > > are incompatible types; GCC and CLANG are right to complain. > > > > Cc: Ard Biesheuvel > > Cc: Jaben Carsey > > Cc: Ruiyu Ni > > Cc: Steven Shi > > Reported-by: Jenkins Build Host > > Reported-by: Steven Shi > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D716 > > Fixes: 09e8678380aaaf0a5ef59179ff59e0a045d1b0bf > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Laszlo Ersek > > --- > > > > Notes: > > I'm going to push this as soon as I get an R-b from anyone. > > >=20 > Reviewed-by: Ard Biesheuvel >=20 > > Thanks > > Laszlo > > > > ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > > index 062ab5dc3a9a..5791da9acc8c 100644 > > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > > @@ -424,7 +424,7 @@ CascadeProcessVariables ( > > CHAR16 *AttrString; > > CHAR16 *HexString; > > EFI_STATUS SetStatus; > > - CHAR16 *GuidName; > > + CONST CHAR16 *GuidName; > > > > if (ShellGetExecutionBreakFlag()) { > > return (SHELL_ABORTED); > > -- > > 2.14.1.3.gb7cf6e02401b > >