From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 479EA21CEB0F7 for ; Fri, 22 Sep 2017 07:03:57 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Sep 2017 07:07:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,427,1500966000"; d="scan'208";a="154363394" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 22 Sep 2017 07:07:05 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 22 Sep 2017 07:07:05 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.182]) by fmsmsx117.amr.corp.intel.com ([169.254.3.51]) with mapi id 14.03.0319.002; Fri, 22 Sep 2017 07:07:04 -0700 From: "Carsey, Jaben" To: "Gao, Liming" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [edk2] [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore Thread-Index: AQHTM20ofixmcllEJkOC4gS0IArrB6LA8OmQ Date: Fri, 22 Sep 2017 14:07:03 +0000 Message-ID: References: <1506062183-7720-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1506062183-7720-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzkxNzFmNDQtN2I4Mi00NTM5LTljZmYtZmE4MTFhNDcwZGJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InFGMVwvbnhySFZtTDEwbWdTMXhCN05nR3V1RWhrckkzTEhRRnBEMEp3cjIwPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [Patch] ShellPkg: Update the parameter type to match function interface in DmpStore X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 14:03:57 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, I agree this works, but I think Laszlo's change to make the GuidNa= me a CONST CHAR makes more sense. Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Liming Gao > Sent: Thursday, September 21, 2017 11:36 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu > Subject: [edk2] [Patch] ShellPkg: Update the parameter type to match > function interface in DmpStore > Importance: High >=20 > This fix can resolve CLANG38 build failure. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Liming Gao > Cc: Ruiyu Ni > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > index 062ab5d..c2b60fe 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > @@ -522,7 +522,7 @@ CascadeProcessVariables ( > Status =3D EFI_OUT_OF_RESOURCES; > } > } else { > - Status =3D gEfiShellProtocol->GetGuidName(&FoundVarGuid, > &GuidName); > + Status =3D gEfiShellProtocol->GetGuidName(&FoundVarGuid, (CONS= T > CHAR16 **) &GuidName); > if (EFI_ERROR (Status)) { > ShellPrintHiiEx ( > -1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_HEADER_LINE), > gShellDebug1HiiHandle, > -- > 2.8.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel