From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EC34121F2AF8C for ; Thu, 28 Sep 2017 06:38:11 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 28 Sep 2017 06:41:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,450,1500966000"; d="scan'208";a="1224790460" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 28 Sep 2017 06:41:26 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 28 Sep 2017 06:41:26 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.182]) by fmsmsx156.amr.corp.intel.com ([169.254.13.144]) with mapi id 14.03.0319.002; Thu, 28 Sep 2017 06:41:25 -0700 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "Bi, Dandan" , "edk2-devel@lists.01.org" Thread-Topic: [patch] ShellPkg/Dh: Refine variable naming style Thread-Index: AQHTOAPgYpOlOoNzJk60W0Z3d9qHVKLKQmAAgAAMhpA= Date: Thu, 28 Sep 2017 13:41:25 +0000 Message-ID: References: <1506566725-444288-1-git-send-email-dandan.bi@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BA6E707@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BA6E707@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzk2Yzk5OTYtNGEzNS00MjgzLWJjODYtZWIzMjAxMzhmODM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InhVckI0ZVVNRkwzTXk3Y2V4VTJCOFdSUWZ2YnhnMGhueHNDd0l0R1h0dUk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [patch] ShellPkg/Dh: Refine variable naming style X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 13:38:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Ni, Ruiyu > Sent: Wednesday, September 27, 2017 10:57 PM > To: Bi, Dandan ; edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [patch] ShellPkg/Dh: Refine variable naming style > Importance: High >=20 > Reviewed-by: Ruiyu Ni >=20 > Thanks/Ray >=20 > > -----Original Message----- > > From: Bi, Dandan > > Sent: Thursday, September 28, 2017 10:45 AM > > To: edk2-devel@lists.01.org > > Cc: Ni, Ruiyu ; Carsey, Jaben > > > Subject: [patch] ShellPkg/Dh: Refine variable naming style > > > > Avoid using only lower-case characters for variable name. > > > > Cc: Ruiyu Ni > > Cc: Jaben Carsey > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Dandan Bi > > --- > > ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > index 7d06163..a7bd251 100644 > > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c > > @@ -284,11 +284,11 @@ GetProtocolInfoString( > > EFI_STATUS Status; > > CHAR16 *RetVal; > > UINTN Size; > > CHAR16 *Temp; > > CHAR16 GuidStr[40]; > > - VOID *instance; > > + VOID *Instance; > > CHAR16 InstanceStr[17]; > > > > ProtocolGuidArray =3D NULL; > > RetVal =3D NULL; > > Size =3D 0; > > @@ -314,14 +314,14 @@ GetProtocolInfoString( > > FreePool(Temp); > > } > > StrnCatGrow(&RetVal, &Size, L"%N", 0); > > > > if(Verbose) { > > - Status =3D gBS->HandleProtocol (TheHandle, > > ProtocolGuidArray[ProtocolIndex], &instance); > > + Status =3D gBS->HandleProtocol (TheHandle, > > ProtocolGuidArray[ProtocolIndex], &Instance); > > if (!EFI_ERROR (Status)) { > > StrnCatGrow (&RetVal, &Size, L"(%H", 0); > > - UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", ins= tance); > > + UnicodeSPrint (InstanceStr, sizeof (InstanceStr), L"%x", Ins= tance); > > StrnCatGrow (&RetVal, &Size, InstanceStr, 0); > > StrnCatGrow (&RetVal, &Size, L"%N)", 0); > > } > > } > > > > -- > > 1.9.5.msysgit.1