public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Li, Huajing" <huajing.li@intel.com>
Subject: Re: [PATCH 2/2] ShellPkg/UefiHandleParsingLib.c: Map SmmPciRootBridgeIo correctly
Date: Thu, 28 Sep 2017 13:42:36 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C752F33E5@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20170928063720.141148-3-ruiyu.ni@intel.com>

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, September 27, 2017 11:37 PM
> To: edk2-devel@lists.01.org
> Cc: Li, Huajing <huajing.li@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>
> Subject: [PATCH 2/2] ShellPkg/UefiHandleParsingLib.c: Map
> SmmPciRootBridgeIo correctly
> Importance: High
> 
> From: Huajing Li <huajing.li@intel.com>
> 
> The current implementation has a typo that maps SmmPciRootBridgeIo
> to "PciRootBridgeIo".
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Huajing Li <huajing.li@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index 06f9d26e5f..489decfaf8 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -2229,7 +2229,7 @@ STATIC CONST GUID_INFO_BLOCK
> mGuidStringList[] = {
>    {STRING_TOKEN(STR_S_COMM),
> &gEfiSmmCommunicationProtocolGuid,                NULL},
>    {STRING_TOKEN(STR_S_STAT),                &gEfiSmmStatusCodeProtocolGuid,
> NULL},
>    {STRING_TOKEN(STR_S_CPU),                 &gEfiSmmCpuProtocolGuid,
> NULL},
> -  {STRING_TOKEN(STR_S_PCIRBIO),
> &gEfiPciRootBridgeIoProtocolGuid,                 NULL},
> +  {STRING_TOKEN(STR_S_PCIRBIO),
> &gEfiSmmPciRootBridgeIoProtocolGuid,              NULL},
>    {STRING_TOKEN(STR_S_SWD),
> &gEfiSmmSwDispatch2ProtocolGuid,                  NULL},
>    {STRING_TOKEN(STR_S_SXD),                 &gEfiSmmSxDispatch2ProtocolGuid,
> NULL},
>    {STRING_TOKEN(STR_S_PTD2),
> &gEfiSmmPeriodicTimerDispatch2ProtocolGuid,       NULL},
> --
> 2.12.2.windows.2



      reply	other threads:[~2017-09-28 13:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28  6:37 [PATCH 0/2] Add mapping of new UEFI/PI protocols Ruiyu Ni
2017-09-28  6:37 ` [PATCH 1/2] ShellPkg/dh: " Ruiyu Ni
2017-09-28 13:42   ` Carsey, Jaben
2017-09-28  6:37 ` [PATCH 2/2] ShellPkg/UefiHandleParsingLib.c: Map SmmPciRootBridgeIo correctly Ruiyu Ni
2017-09-28 13:42   ` Carsey, Jaben [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C752F33E5@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox