public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 1/2] ShellPkg/dh: Correct typo in help
Date: Thu, 28 Sep 2017 18:30:02 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C752F3F75@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20170928172123.152656-2-ruiyu.ni@intel.com>

Ray,

This text is taken directly from the shell spec.  Do we need to fix that also?

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Thursday, September 28, 2017 10:21 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH 1/2] ShellPkg/dh: Correct typo in help
> Importance: High
> 
> Help message of "dh" gives an example to display all handles
> with "Image" protocol but actually "LoadedImage" protocol should
> be used.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  .../UefiShellDriver1CommandsLib/UefiShellDriver1CommandsLib.uni       | 4
> ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman
> dsLib.uni
> index e4bff68838..3804fa7d28 100644
> ---
> a/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Command
> sLib.uni
> +++
> b/ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Comman
> dsLib.uni
> @@ -401,9 +401,9 @@
>  "  * To display all handles with 'diskio' protocol:\r\n"
>  "    Shell> dh -p diskio\r\n"
>  " \r\n"
> -"  * To display all handles with 'Image' protocol and break when the screen
> is\r\n"
> +"  * To display all handles with 'LoadedImage' protocol and break when the
> screen is\r\n"
>  "    full:\r\n"
> -"    Shell> dh -p Image -b\r\n"
> +"    Shell> dh -p LoadedImage -b\r\n"
>  ".SH RETURNVALUES\r\n"
>  " \r\n"
>  "RETURN VALUES:\r\n"
> --
> 2.12.2.windows.2



  reply	other threads:[~2017-09-28 18:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28 17:21 [PATCH 0/2] Correct typo in command help Ruiyu Ni
2017-09-28 17:21 ` [PATCH 1/2] ShellPkg/dh: Correct typo in help Ruiyu Ni
2017-09-28 18:30   ` Carsey, Jaben [this message]
2017-09-29  0:26     ` Ni, Ruiyu
2017-09-28 17:21 ` [PATCH 2/2] ShellPkg/disconnect: '-r' is not optional when disconnecting all Ruiyu Ni
2017-09-28 18:30 ` [PATCH 0/2] Correct typo in command help Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C752F3F75@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox