From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4EFFC202E5CDE for ; Mon, 16 Oct 2017 09:28:47 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2017 09:32:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,387,1503385200"; d="scan'208";a="323844092" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 16 Oct 2017 09:32:22 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.182]) by FMSMSX105.amr.corp.intel.com ([169.254.4.92]) with mapi id 14.03.0319.002; Mon, 16 Oct 2017 09:32:22 -0700 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color Thread-Index: AQHTRlDQj4H2PMcB1Uy8uEOtCffL96Lmq9rw Date: Mon, 16 Oct 2017 16:32:21 +0000 Message-ID: References: <20171016073048.236980-1-ruiyu.ni@intel.com> In-Reply-To: <20171016073048.236980-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2IzZmQyOTktYzM5Yi00Zjc0LWJkMzAtM2VhYzVlOTA1ZTYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im4zZXBER25idWNQNzNJYnE5QkNBNEx5SGx3TTJvdEU3ZGtvbWtqcWZWQ009In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green color X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 16:28:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey We could also use some PCDs if different people really want different color= s in the future... > -----Original Message----- > From: Ni, Ruiyu > Sent: Monday, October 16, 2017 12:31 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/UefiShellLib: Use a more bright blue/green colo= r > Importance: High >=20 > Some developers/QAs complain the color of directory or executable > files is hard to see and suggest to use a more bright color. > I agree with this suggestion so make this patch. > The look and feel is much better now. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jaben Carsey > --- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 64565f81d8..25d3e33533 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -2849,10 +2849,10 @@ InternalShellPrintWorker( > gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_WHITE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'B'): > - gST->ConOut->SetAttribute(gST->ConOut, EFI_TEXT_ATTR(EFI_BLU= E, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTBLUE, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > case (L'V'): > - gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_GREEN, ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > + gST->ConOut->SetAttribute(gST->ConOut, > EFI_TEXT_ATTR(EFI_LIGHTGREEN, > ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))); > break; > default: > // > -- > 2.12.2.windows.2