* [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint call
@ 2017-10-24 5:38 Ruiyu Ni
2017-10-24 14:26 ` Carsey, Jaben
0 siblings, 1 reply; 2+ messages in thread
From: Ruiyu Ni @ 2017-10-24 5:38 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
index 15103160d9..d343f3352e 100644
--- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
+++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
@@ -259,9 +259,7 @@ LoadedImageProtocolDumpInformation(
} else {
SHELL_FREE_NON_NULL(FilePath);
}
- RetVal = CatSPrint(NULL, FileName);
- SHELL_FREE_NON_NULL(FileName);
- return RetVal;
+ return FileName;
}
HandleParsingHiiInit();
--
2.12.2.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint call
2017-10-24 5:38 [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint call Ruiyu Ni
@ 2017-10-24 14:26 ` Carsey, Jaben
0 siblings, 0 replies; 2+ messages in thread
From: Carsey, Jaben @ 2017-10-24 14:26 UTC (permalink / raw)
To: Ni, Ruiyu, edk2-devel@lists.01.org
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Monday, October 23, 2017 10:38 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint
> call
> Importance: High
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
> ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index 15103160d9..d343f3352e 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -259,9 +259,7 @@ LoadedImageProtocolDumpInformation(
> } else {
> SHELL_FREE_NON_NULL(FilePath);
> }
> - RetVal = CatSPrint(NULL, FileName);
> - SHELL_FREE_NON_NULL(FileName);
> - return RetVal;
> + return FileName;
> }
>
> HandleParsingHiiInit();
> --
> 2.12.2.windows.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-24 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-24 5:38 [PATCH] ShellPkg/HandleParsingLib: Remove unnecessary CatSPrint call Ruiyu Ni
2017-10-24 14:26 ` Carsey, Jaben
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox