public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Jim.Dailey@dell.com" <Jim.Dailey@dell.com>,
	"Ni, Ruiyu" <ruiyu.ni@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: Shell Non-conformity to the Spec
Date: Tue, 24 Oct 2017 18:28:56 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C753119AA@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <4d26cd8872634973b7d38388dc5a0d20@ausx13mps335.AMER.DELL.COM>

Yes.

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jim.Dailey@dell.com
> Sent: Tuesday, October 24, 2017 11:20 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Cc: edk2-devel@lists.01.org
> Subject: [edk2] Shell Non-conformity to the Spec
> Importance: High
> 
> The shell spec says that "Each environment variable has a case-sensitive
> name ...".
> 
> In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive
> compare is performed against the variable that is to be set to see if it
> is one of the read-only variables.  That means one cannot set a variable
> named, for example, CWD, even though "cwd" and "CWD" are two different
> variable names according to the spec.
> 
> Should this be changed to a case-sensitive comparison?
> 
> Regards,
> Jim
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2017-10-24 18:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 18:20 Shell Non-conformity to the Spec Jim.Dailey
2017-10-24 18:28 ` Carsey, Jaben [this message]
2017-10-24 19:14   ` Tim Lewis
2017-10-24 20:11     ` Carsey, Jaben
2017-10-24 20:13       ` Tim Lewis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515C753119AA@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox