From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 79A0321CEB15A for ; Tue, 24 Oct 2017 11:25:14 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2017 11:28:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,428,1503385200"; d="scan'208";a="913286091" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 24 Oct 2017 11:28:57 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Oct 2017 11:28:57 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.182]) by FMSMSX112.amr.corp.intel.com ([169.254.5.121]) with mapi id 14.03.0319.002; Tue, 24 Oct 2017 11:28:57 -0700 From: "Carsey, Jaben" To: "Jim.Dailey@dell.com" , "Ni, Ruiyu" CC: "edk2-devel@lists.01.org" Thread-Topic: [edk2] Shell Non-conformity to the Spec Thread-Index: AdNM9Lj2jKcRKf57QF61B1qheMChVAAAJuAg Date: Tue, 24 Oct 2017 18:28:56 +0000 Message-ID: References: <4d26cd8872634973b7d38388dc5a0d20@ausx13mps335.AMER.DELL.COM> In-Reply-To: <4d26cd8872634973b7d38388dc5a0d20@ausx13mps335.AMER.DELL.COM> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDY1Yzk5NDItNDdhNy00ODA5LTkwZTctMDA0ZTU1ODE3NmQ0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkRlekM1WWVpNVEzODhWNmorVlNhR3V2RGEzeE9VblVNNGw1dnBmM0M1Q2c9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: Shell Non-conformity to the Spec X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 18:25:14 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jim.Dailey@dell.com > Sent: Tuesday, October 24, 2017 11:20 AM > To: Carsey, Jaben ; Ni, Ruiyu > Cc: edk2-devel@lists.01.org > Subject: [edk2] Shell Non-conformity to the Spec > Importance: High >=20 > The shell spec says that "Each environment variable has a case-sensitive > name ...". >=20 > In the EfiShellSetEnv function of ShellProtocol.c a case-insensitive > compare is performed against the variable that is to be set to see if it > is one of the read-only variables. That means one cannot set a variable > named, for example, CWD, even though "cwd" and "CWD" are two different > variable names according to the spec. >=20 > Should this be changed to a case-sensitive comparison? >=20 > Regards, > Jim >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel