From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [PATCH] Shellpkg/editor: Fix a bug that may modifies Line[-1]
Date: Wed, 25 Oct 2017 14:04:05 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C75313109@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20171025010308.53424-1-ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Tuesday, October 24, 2017 6:03 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Wu, Hao A
> <hao.a.wu@intel.com>
> Subject: [PATCH] Shellpkg/editor: Fix a bug that may modifies Line[-1]
> Importance: High
>
> The original code as below intend to set the character
> before last column to CHAR_NULL.
> Line[(LastCol % (ARRAY_SIZE (Line) - 1)) - 1] = CHAR_NULL;
>
> But when LastCol % (ARRAY_SIZE (Line) - 1)) equals to 0,
> Line[-1] is modified.
>
> We should change to code as below:
> Line[(LastCol - 1) % (ARRAY_SIZE (Line) - 1)] = CHAR_NULL;
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> ---
> .../Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.c
> | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.c
> index d26d08f95c..b45e9a33f3 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Comman
> dsLib.c
> @@ -205,7 +205,7 @@ EditorClearLine (
> //
> // if CHAR_NULL is still at position LastCol, it will cause first line error
> //
> - Line[(LastCol % (ARRAY_SIZE (Line) - 1)) - 1] = CHAR_NULL;
> + Line[(LastCol - 1) % (ARRAY_SIZE (Line) - 1)] = CHAR_NULL;
> } else {
> Line[LastCol % (ARRAY_SIZE (Line) - 1)] = CHAR_NULL;
> }
> --
> 2.12.2.windows.2
next prev parent reply other threads:[~2017-10-25 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 1:03 [PATCH] Shellpkg/editor: Fix a bug that may modifies Line[-1] Ruiyu Ni
2017-10-25 14:04 ` Carsey, Jaben [this message]
2017-10-26 1:38 ` Wu, Hao A
2017-10-26 1:42 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515C75313109@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox