public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg/HexEdit: Fix EBC build failure
Date: Fri, 3 Nov 2017 14:08:33 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA3BC2014@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20171103085845.127672-1-ruiyu.ni@intel.com>

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Friday, November 03, 2017 1:59 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH] ShellPkg/HexEdit: Fix EBC build failure
> Importance: High
> 
> EfiCpuIoWidthUint8 should be used in HMemImageRead and
> HMemImageSave.
> Because CpuIo protocol is now used for memory access.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c | 4
> ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> index fce9bbe0e6..12f1492583 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> @@ -139,7 +139,7 @@ HMemImageRead (
> 
>    Status = HMemImage.IoFncs->Mem.Read (
>                                    HMemImage.IoFncs,
> -                                  EfiPciWidthUint8,
> +                                  EfiCpuIoWidthUint8,
>                                    Offset,
>                                    Size,
>                                    Buffer
> @@ -262,7 +262,7 @@ HMemImageSave (
>    //
>    Status = HMemImage.IoFncs->Mem.Write (
>                                    HMemImage.IoFncs,
> -                                  EfiPciWidthUint8,
> +                                  EfiCpuIoWidthUint8,
>                                    Offset,
>                                    Size,
>                                    Buffer
> --
> 2.12.2.windows.2



  reply	other threads:[~2017-11-03 14:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-03  8:58 [PATCH] ShellPkg/HexEdit: Fix EBC build failure Ruiyu Ni
2017-11-03 14:08 ` Carsey, Jaben [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-11-03  8:56 Ruiyu Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515CA3BC2014@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox