From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 78572203555FC for ; Fri, 3 Nov 2017 07:04:40 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP; 03 Nov 2017 07:08:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,339,1505804400"; d="scan'208";a="171602477" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 03 Nov 2017 07:08:35 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 3 Nov 2017 07:08:34 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.117]) by fmsmsx156.amr.corp.intel.com ([169.254.13.144]) with mapi id 14.03.0319.002; Fri, 3 Nov 2017 07:08:34 -0700 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] ShellPkg/HexEdit: Fix EBC build failure Thread-Index: AQHTVIH+P0BgjvU20Uy04qbmcW2glqMCsW6g Date: Fri, 3 Nov 2017 14:08:33 +0000 Message-ID: References: <20171103085845.127672-1-ruiyu.ni@intel.com> In-Reply-To: <20171103085845.127672-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWFjZmQzNjgtNDhhZi00NmNlLWJiYzMtNzU5OWM4YTdiYzIzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InhRMVhUSzRhbW9vXC9ZaStldWxQRFBKbzJ0VWoxYlZMYWU4OWhBTDBhSWZvPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/HexEdit: Fix EBC build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 14:04:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Ni, Ruiyu > Sent: Friday, November 03, 2017 1:59 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/HexEdit: Fix EBC build failure > Importance: High >=20 > EfiCpuIoWidthUint8 should be used in HMemImageRead and > HMemImageSave. > Because CpuIo protocol is now used for memory access. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jaben Carsey > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c | 4 > ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c > index fce9bbe0e6..12f1492583 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c > @@ -139,7 +139,7 @@ HMemImageRead ( >=20 > Status =3D HMemImage.IoFncs->Mem.Read ( > HMemImage.IoFncs, > - EfiPciWidthUint8, > + EfiCpuIoWidthUint8, > Offset, > Size, > Buffer > @@ -262,7 +262,7 @@ HMemImageSave ( > // > Status =3D HMemImage.IoFncs->Mem.Write ( > HMemImage.IoFncs, > - EfiPciWidthUint8, > + EfiCpuIoWidthUint8, > Offset, > Size, > Buffer > -- > 2.12.2.windows.2