* [PATCH] ShellPkg/HexEdit: Fix EBC build failure
@ 2017-11-03 8:58 Ruiyu Ni
2017-11-03 14:08 ` Carsey, Jaben
0 siblings, 1 reply; 3+ messages in thread
From: Ruiyu Ni @ 2017-11-03 8:58 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben Carsey
EfiCpuIoWidthUint8 should be used in HMemImageRead and HMemImageSave.
Because CpuIo protocol is now used for memory access.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
---
ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
index fce9bbe0e6..12f1492583 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
@@ -139,7 +139,7 @@ HMemImageRead (
Status = HMemImage.IoFncs->Mem.Read (
HMemImage.IoFncs,
- EfiPciWidthUint8,
+ EfiCpuIoWidthUint8,
Offset,
Size,
Buffer
@@ -262,7 +262,7 @@ HMemImageSave (
//
Status = HMemImage.IoFncs->Mem.Write (
HMemImage.IoFncs,
- EfiPciWidthUint8,
+ EfiCpuIoWidthUint8,
Offset,
Size,
Buffer
--
2.12.2.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ShellPkg/HexEdit: Fix EBC build failure
2017-11-03 8:58 [PATCH] ShellPkg/HexEdit: Fix EBC build failure Ruiyu Ni
@ 2017-11-03 14:08 ` Carsey, Jaben
0 siblings, 0 replies; 3+ messages in thread
From: Carsey, Jaben @ 2017-11-03 14:08 UTC (permalink / raw)
To: Ni, Ruiyu, edk2-devel@lists.01.org
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Friday, November 03, 2017 1:59 AM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH] ShellPkg/HexEdit: Fix EBC build failure
> Importance: High
>
> EfiCpuIoWidthUint8 should be used in HMemImageRead and
> HMemImageSave.
> Because CpuIo protocol is now used for memory access.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c | 4
> ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> index fce9bbe0e6..12f1492583 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
> @@ -139,7 +139,7 @@ HMemImageRead (
>
> Status = HMemImage.IoFncs->Mem.Read (
> HMemImage.IoFncs,
> - EfiPciWidthUint8,
> + EfiCpuIoWidthUint8,
> Offset,
> Size,
> Buffer
> @@ -262,7 +262,7 @@ HMemImageSave (
> //
> Status = HMemImage.IoFncs->Mem.Write (
> HMemImage.IoFncs,
> - EfiPciWidthUint8,
> + EfiCpuIoWidthUint8,
> Offset,
> Size,
> Buffer
> --
> 2.12.2.windows.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ShellPkg/HexEdit: Fix EBC build failure
@ 2017-11-03 8:56 Ruiyu Ni
0 siblings, 0 replies; 3+ messages in thread
From: Ruiyu Ni @ 2017-11-03 8:56 UTC (permalink / raw)
To: edk2-devel; +Cc: Jaben, Carsey
EfiCpuIoWidthUint8 should be used in HMemImageRead and HMemImageSave.
Because CpuIo protocol is now used for memory access.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey@intel.com>
---
ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
index fce9bbe0e6..12f1492583 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MemImage.c
@@ -139,7 +139,7 @@ HMemImageRead (
Status = HMemImage.IoFncs->Mem.Read (
HMemImage.IoFncs,
- EfiPciWidthUint8,
+ EfiCpuIoWidthUint8,
Offset,
Size,
Buffer
@@ -262,7 +262,7 @@ HMemImageSave (
//
Status = HMemImage.IoFncs->Mem.Write (
HMemImage.IoFncs,
- EfiPciWidthUint8,
+ EfiCpuIoWidthUint8,
Offset,
Size,
Buffer
--
2.12.2.windows.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-03 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-03 8:58 [PATCH] ShellPkg/HexEdit: Fix EBC build failure Ruiyu Ni
2017-11-03 14:08 ` Carsey, Jaben
-- strict thread matches above, loose matches on Subject: below --
2017-11-03 8:56 Ruiyu Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox