From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo
Date: Tue, 7 Nov 2017 14:53:28 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA3BC8FFC@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20171107073445.190652-1-ruiyu.ni@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Monday, November 06, 2017 11:35 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping
> PciRootBridgeIo
> Importance: High
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> ---
> ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> index d343f3352e..b7b0246ac9 100644
> --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c
> @@ -682,7 +682,7 @@ PciRootBridgeIoDumpInformation(
> break;
> }
> if (Temp != NULL) {
> - Temp2 = CatSPrint(RetVal, L"%s", Temp);
> + Temp2 = CatSPrint(RetVal, L"\r\n%s", Temp);
> FreePool(Temp);
> FreePool(RetVal);
> RetVal = Temp2;
> @@ -690,7 +690,7 @@ PciRootBridgeIoDumpInformation(
> }
>
> Temp2 = CatSPrint(RetVal,
> - L"\r\n%%H%02x %016lx %016lx %02x%%N",
> + L"%%H%02x %016lx %016lx %02x%%N",
> Configuration->SpecificFlag,
> Configuration->AddrRangeMin,
> Configuration->AddrRangeMax,
> --
> 2.12.2.windows.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2017-11-07 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 7:34 [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo Ruiyu Ni
2017-11-07 14:53 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA3BC8FFC@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox