From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3F82321C913AB for ; Tue, 7 Nov 2017 06:49:30 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Nov 2017 06:53:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,359,1505804400"; d="scan'208";a="146909043" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 07 Nov 2017 06:53:29 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 7 Nov 2017 06:53:28 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.117]) by fmsmsx156.amr.corp.intel.com ([169.254.13.144]) with mapi id 14.03.0319.002; Tue, 7 Nov 2017 06:53:28 -0800 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo Thread-Index: AQHTV5rvz4KRyRSZA064m9nzf+zvqKMJARtQ Date: Tue, 7 Nov 2017 14:53:28 +0000 Message-ID: References: <20171107073445.190652-1-ruiyu.ni@intel.com> In-Reply-To: <20171107073445.190652-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDNiYTQzYTgtYzBlNy00M2QyLWJmYzYtOTQ0OTNmZWI1YmQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZkaW5NNytzdU9vd0Q0WXRLOTRQVjFZTFwvQ2J2MU9iQXA4UHdTSHUzS3FjPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/dh: Fix wrong output when dumping PciRootBridgeIo X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Nov 2017 14:49:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Monday, November 06, 2017 11:35 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [edk2] [PATCH] ShellPkg/dh: Fix wrong output when dumping > PciRootBridgeIo > Importance: High >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jaben Carsey > --- > ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > index d343f3352e..b7b0246ac9 100644 > --- a/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > +++ b/ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.c > @@ -682,7 +682,7 @@ PciRootBridgeIoDumpInformation( > break; > } > if (Temp !=3D NULL) { > - Temp2 =3D CatSPrint(RetVal, L"%s", Temp); > + Temp2 =3D CatSPrint(RetVal, L"\r\n%s", Temp); > FreePool(Temp); > FreePool(RetVal); > RetVal =3D Temp2; > @@ -690,7 +690,7 @@ PciRootBridgeIoDumpInformation( > } >=20 > Temp2 =3D CatSPrint(RetVal, > - L"\r\n%%H%02x %016lx %016lx %02x%%N", > + L"%%H%02x %016lx %016lx %02x%%N", > Configuration->SpecificFlag, > Configuration->AddrRangeMin, > Configuration->AddrRangeMax, > -- > 2.12.2.windows.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel