From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 311BE20355222 for ; Fri, 10 Nov 2017 06:44:06 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Nov 2017 06:48:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,374,1505804400"; d="scan'208";a="576014" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 10 Nov 2017 06:48:09 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 10 Nov 2017 06:48:08 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.117]) by fmsmsx115.amr.corp.intel.com ([169.254.4.50]) with mapi id 14.03.0319.002; Fri, 10 Nov 2017 06:48:08 -0800 From: "Carsey, Jaben" To: "Song, BinX" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [PATCH V2 5/5] ShellPkg: Fix MSFT C4255 warning Thread-Index: AdNZ2f64FobU6yRVQjyLEXMd5SAwgAAWOrLw Date: Fri, 10 Nov 2017 14:48:07 +0000 Message-ID: References: <559D2DF22BC9A3468B4FA1AA547F0EF1025BD6C2@shsmsx102.ccr.corp.intel.com> In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF1025BD6C2@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTE3NDZhMDktZWZjMy00NWYzLThiZGEtODg5NjFjNGJhNjM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IklkXC9MSU9LK041Z0FjVTlIaGUweGF6TGVablNiTlwvaWNYTmVRK0VKbmdoYz0ifQ== x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH V2 5/5] ShellPkg: Fix MSFT C4255 warning X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Nov 2017 14:44:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Song, BinX > Sent: Thursday, November 09, 2017 8:12 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: [edk2] [PATCH V2 5/5] ShellPkg: Fix MSFT C4255 warning > Importance: High >=20 > V2: > Fix MSFT C4255 warning > V1: > Enable MSFT C4255 warning. >=20 > From MSDN: > Compiler Warning (level 4) C4255 > function' : no function prototype given: converting '()' to '(void)' > The compiler did not find an explicit list of arguments to a function. > This warning is for the C compiler only. >=20 > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Bell Song > --- > ShellPkg/Application/Shell/Shell.c | 1 + > ShellPkg/Application/Shell/ShellProtocol.c | 2 ++ > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 1 + > 3 files changed, 4 insertions(+) >=20 > diff --git a/ShellPkg/Application/Shell/Shell.c > b/ShellPkg/Application/Shell/Shell.c > index 656206f..2adc992 100644 > --- a/ShellPkg/Application/Shell/Shell.c > +++ b/ShellPkg/Application/Shell/Shell.c > @@ -726,6 +726,7 @@ FreeResources: > **/ > EFI_STATUS > SetBuiltInAlias( > + VOID > ) > { > EFI_STATUS Status; > diff --git a/ShellPkg/Application/Shell/ShellProtocol.c > b/ShellPkg/Application/Shell/ShellProtocol.c > index 5e34b8d..dc3deee 100644 > --- a/ShellPkg/Application/Shell/ShellProtocol.c > +++ b/ShellPkg/Application/Shell/ShellProtocol.c > @@ -1679,6 +1679,7 @@ InternalShellExecute( > STATIC > BOOLEAN > NestingEnabled( > + VOID > ) > { > EFI_STATUS Status; > @@ -3286,6 +3287,7 @@ EfiShellIsRootShell( > **/ > CHAR16 * > InternalEfiShellGetListAlias( > + VOID > ) > { >=20 > diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > index 25d3e33..677791c 100644 > --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c > +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c > @@ -369,6 +369,7 @@ ShellLibDestructor ( > EFI_STATUS > EFIAPI > ShellInitialize ( > + VOID > ) > { > EFI_STATUS Status; > -- > 2.10.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel