[PATCH V2 5/5] ShellPkg: Fix MSFT C4255 warning

[PATCH V2 5/5] ShellPkg: Fix MSFT C4255 warning

[Song, BinX]

V2:
Fix MSFT C4255 warning
V1:
Enable MSFT C4255 warning.

>From MSDN:
Compiler Warning (level 4) C4255
function' : no function prototype given: converting '()' to '(void)'
The compiler did not find an explicit list of arguments to a function.
This warning is for the C compiler only.

Cc: Liming Gao <liming.gao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Bell Song <binx.song@intel.com>
---
 ShellPkg/Application/Shell/Shell.c           | 1 +
 ShellPkg/Application/Shell/ShellProtocol.c   | 2 ++
 ShellPkg/Library/UefiShellLib/UefiShellLib.c | 1 +
 3 files changed, 4 insertions(+)

diff --git a/ShellPkg/Application/Shell/Shell.c b/ShellPkg/Application/Shell/Shell.c
index 656206f..2adc992 100644
--- a/ShellPkg/Application/Shell/Shell.c
+++ b/ShellPkg/Application/Shell/Shell.c
@@ -726,6 +726,7 @@ FreeResources:
 **/
 EFI_STATUS
 SetBuiltInAlias(
+  VOID
   )
 {
   EFI_STATUS          Status;
diff --git a/ShellPkg/Application/Shell/ShellProtocol.c b/ShellPkg/Application/Shell/ShellProtocol.c
index 5e34b8d..dc3deee 100644
--- a/ShellPkg/Application/Shell/ShellProtocol.c
+++ b/ShellPkg/Application/Shell/ShellProtocol.c
@@ -1679,6 +1679,7 @@ InternalShellExecute(
 STATIC
 BOOLEAN
 NestingEnabled(
+  VOID
 )
 {
   EFI_STATUS  Status;
@@ -3286,6 +3287,7 @@ EfiShellIsRootShell(
 **/
 CHAR16 *
 InternalEfiShellGetListAlias(
+  VOID
   )
 {
   
diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
index 25d3e33..677791c 100644
--- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
+++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
@@ -369,6 +369,7 @@ ShellLibDestructor (
 EFI_STATUS
 EFIAPI
 ShellInitialize (
+  VOID
   )
 {
   EFI_STATUS Status;
-- 
2.10.2.windows.1

Re: [PATCH V2 5/5] ShellPkg: Fix MSFT C4255 warning

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Song, BinX
> Sent: Thursday, November 09, 2017 8:12 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH V2 5/5] ShellPkg: Fix MSFT C4255 warning
> Importance: High
> 
> V2:
> Fix MSFT C4255 warning
> V1:
> Enable MSFT C4255 warning.
> 
> From MSDN:
> Compiler Warning (level 4) C4255
> function' : no function prototype given: converting '()' to '(void)'
> The compiler did not find an explicit list of arguments to a function.
> This warning is for the C compiler only.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Bell Song <binx.song@intel.com>
> ---
>  ShellPkg/Application/Shell/Shell.c           | 1 +
>  ShellPkg/Application/Shell/ShellProtocol.c   | 2 ++
>  ShellPkg/Library/UefiShellLib/UefiShellLib.c | 1 +
>  3 files changed, 4 insertions(+)
> 
> diff --git a/ShellPkg/Application/Shell/Shell.c
> b/ShellPkg/Application/Shell/Shell.c
> index 656206f..2adc992 100644
> --- a/ShellPkg/Application/Shell/Shell.c
> +++ b/ShellPkg/Application/Shell/Shell.c
> @@ -726,6 +726,7 @@ FreeResources:
>  **/
>  EFI_STATUS
>  SetBuiltInAlias(
> +  VOID
>    )
>  {
>    EFI_STATUS          Status;
> diff --git a/ShellPkg/Application/Shell/ShellProtocol.c
> b/ShellPkg/Application/Shell/ShellProtocol.c
> index 5e34b8d..dc3deee 100644
> --- a/ShellPkg/Application/Shell/ShellProtocol.c
> +++ b/ShellPkg/Application/Shell/ShellProtocol.c
> @@ -1679,6 +1679,7 @@ InternalShellExecute(
>  STATIC
>  BOOLEAN
>  NestingEnabled(
> +  VOID
>  )
>  {
>    EFI_STATUS  Status;
> @@ -3286,6 +3287,7 @@ EfiShellIsRootShell(
>  **/
>  CHAR16 *
>  InternalEfiShellGetListAlias(
> +  VOID
>    )
>  {
> 
> diff --git a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> index 25d3e33..677791c 100644
> --- a/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> +++ b/ShellPkg/Library/UefiShellLib/UefiShellLib.c
> @@ -369,6 +369,7 @@ ShellLibDestructor (
>  EFI_STATUS
>  EFIAPI
>  ShellInitialize (
> +  VOID
>    )
>  {
>    EFI_STATUS Status;
> --
> 2.10.2.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel