public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: Michael Zimmermann <sigmaepsilon92@gmail.com>,
	Laszlo Ersek <lersek@redhat.com>
Cc: edk2 developers list <edk2-devel@lists.01.org>
Subject: Re: stdlib broken strncasecmp.c
Date: Mon, 13 Nov 2017 21:37:20 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA3BD102E@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <CAN9vWD+wUX1Yvsu4D+kSmz8jZhwfiiy6FF-8Feu2t8QvhtHewQ@mail.gmail.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Michael Zimmermann
> Sent: Monday, November 13, 2017 11:58 AM
> To: Laszlo Ersek <lersek@redhat.com>
> Cc: edk2 developers list <edk2-devel@lists.01.org>
> Subject: Re: [edk2] stdlib broken strncasecmp.c
> 
> > I've been subscribed to edk2-devel (wherever it lived whenever) since
> > approx. April 2012. So, I checked all my yearly archives, and the only
> > year where the search expression "df7729 patch" returns at least one hit
> > is 2013. Please don't judge the project's development process from a
> > four year old experience, there have been many changes.
> For StdLib I actually have the same experience(from 1-2 years ago).
> Patches either never get responded to or just forgotten after a long
> discussion.

I am trying to stay on top of patches.  

I get lots of email.  If I don't get CC'd on the email, I freely admit that I have a higher risk of missing your email.  I know I got poked just today about a patch that did not CC me and I had missed it.  But that patch has been pushed.  This is not saying that patches were not missed in the past, but the goal is to fix the situation going forwards.

-Jaben


> 
> Thanks
> Michael
> 
> On Mon, Nov 13, 2017 at 2:28 PM, Laszlo Ersek <lersek@redhat.com> wrote:
> > Hi,
> >
> > On 11/10/17 20:09, David F. wrote:
> >> I would submit a patch but over the years of fixes and enhancements,
> >> they don't go anywhere. Then a couple years later someone does a
> >> half-baked fix and I have to run merge resolution on svn.
> >
> > I've been subscribed to edk2-devel (wherever it lived whenever) since
> > approx. April 2012. So, I checked all my yearly archives, and the only
> > year where the search expression "df7729 patch" returns at least one hit
> > is 2013. Please don't judge the project's development process from a
> > four year old experience, there have been many changes.
> >
> > Please consider submitting a patch with git:
> >
> > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-
> Development-Process
> >
> > (Optional reading:
> > <https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-
> git-guide-for-edk2-contributors-and-maintainers>.)
> >
> > Please don't forget to CC the StdLib maintainers on your patch -- they
> > are listed in "Maintainers.txt".
> >
> >> Anyway, the problem with that is the s1 compare to 0 should be before
> >> the s1++ (otherwise it matches when the s1 string is shorter than the
> >> s2 string).
> >
> > If you don't feel like posting a patch with git, can you perhaps
> > register in the TianoCore Bugzilla, and file a bug report there?
> >
> >   https://bugzilla.tianocore.org/
> >
> >   Product:   EDK2
> >   Component: Code
> >   Package:   StdLib
> >
> > Thanks!
> > Laszlo
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2017-11-13 21:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10 19:09 stdlib broken strncasecmp.c David F.
2017-11-13 13:28 ` Laszlo Ersek
2017-11-13 19:58   ` Michael Zimmermann
2017-11-13 21:37     ` Carsey, Jaben [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515CA3BD102E@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox