From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 49EE9202E5E5D for ; Mon, 13 Nov 2017 13:33:18 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2017 13:37:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,389,1505804400"; d="scan'208";a="173109807" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 13 Nov 2017 13:37:21 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 13 Nov 2017 13:37:20 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.117]) by FMSMSX154.amr.corp.intel.com ([169.254.6.140]) with mapi id 14.03.0319.002; Mon, 13 Nov 2017 13:37:20 -0800 From: "Carsey, Jaben" To: Michael Zimmermann , Laszlo Ersek CC: edk2 developers list Thread-Topic: [edk2] stdlib broken strncasecmp.c Thread-Index: AQHTWleLDc/eEP7kEE2/jQlzMF33YKMS2AWAgABs1wD//5SrQA== Date: Mon, 13 Nov 2017 21:37:20 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjMxYmNjNzUtNWUzNS00MzYwLTkwOTEtNGY3YWM3NGQ4ZjEzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImdldjE0eHhrVUJCWG9tbFdDdDRJOTR2K201b3JPbm54MXhVWlQxdHhyRGM9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: stdlib broken strncasecmp.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 21:33:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Michael Zimmermann > Sent: Monday, November 13, 2017 11:58 AM > To: Laszlo Ersek > Cc: edk2 developers list > Subject: Re: [edk2] stdlib broken strncasecmp.c >=20 > > I've been subscribed to edk2-devel (wherever it lived whenever) since > > approx. April 2012. So, I checked all my yearly archives, and the only > > year where the search expression "df7729 patch" returns at least one hi= t > > is 2013. Please don't judge the project's development process from a > > four year old experience, there have been many changes. > For StdLib I actually have the same experience(from 1-2 years ago). > Patches either never get responded to or just forgotten after a long > discussion. I am trying to stay on top of patches. =20 I get lots of email. If I don't get CC'd on the email, I freely admit that= I have a higher risk of missing your email. I know I got poked just today= about a patch that did not CC me and I had missed it. But that patch has = been pushed. This is not saying that patches were not missed in the past, = but the goal is to fix the situation going forwards. -Jaben >=20 > Thanks > Michael >=20 > On Mon, Nov 13, 2017 at 2:28 PM, Laszlo Ersek wrote: > > Hi, > > > > On 11/10/17 20:09, David F. wrote: > >> I would submit a patch but over the years of fixes and enhancements, > >> they don't go anywhere. Then a couple years later someone does a > >> half-baked fix and I have to run merge resolution on svn. > > > > I've been subscribed to edk2-devel (wherever it lived whenever) since > > approx. April 2012. So, I checked all my yearly archives, and the only > > year where the search expression "df7729 patch" returns at least one hi= t > > is 2013. Please don't judge the project's development process from a > > four year old experience, there have been many changes. > > > > Please consider submitting a patch with git: > > > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II- > Development-Process > > > > (Optional reading: > > git-guide-for-edk2-contributors-and-maintainers>.) > > > > Please don't forget to CC the StdLib maintainers on your patch -- they > > are listed in "Maintainers.txt". > > > >> Anyway, the problem with that is the s1 compare to 0 should be before > >> the s1++ (otherwise it matches when the s1 string is shorter than the > >> s2 string). > > > > If you don't feel like posting a patch with git, can you perhaps > > register in the TianoCore Bugzilla, and file a bug report there? > > > > https://bugzilla.tianocore.org/ > > > > Product: EDK2 > > Component: Code > > Package: StdLib > > > > Thanks! > > Laszlo > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel