From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 842CC22183C8B for ; Fri, 1 Dec 2017 08:55:58 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Dec 2017 09:00:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,346,1508828400"; d="scan'208";a="14266098" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 01 Dec 2017 09:00:24 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.117]) by FMSMSX105.amr.corp.intel.com ([169.254.4.92]) with mapi id 14.03.0319.002; Fri, 1 Dec 2017 09:00:23 -0800 From: "Carsey, Jaben" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] ShellPkg/ShellPkg.dec: Change comments for PcdShellLibAutoInitialize Thread-Index: AQHTaOsmVCkvRsiSrEepKy374tSpAaMuudhg Date: Fri, 1 Dec 2017 17:00:22 +0000 Message-ID: References: <20171129082205.269556-1-ruiyu.ni@intel.com> In-Reply-To: <20171129082205.269556-1-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmYwY2E2ZWItOTgzYS00Y2M3LTljNmQtMWM1NmYwMTdmNTg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IldKZERkKyt5QjVzelFBNnkrWEZpMXRqXC9JeXdaVVc0NFMrV1BySGtZQ2w0PSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/ShellPkg.dec: Change comments for PcdShellLibAutoInitialize X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 16:55:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Apologies for delay. I missed the email on first pass. Reviewed-by: Jaben Carsey > -----Original Message----- > From: Ni, Ruiyu > Sent: Wednesday, November 29, 2017 12:22 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: [PATCH] ShellPkg/ShellPkg.dec: Change comments for > PcdShellLibAutoInitialize > Importance: High >=20 > When Dynamic command drivers links to ShellLib, the ShellLib > constructor shouldn't be called because the Shell and ShellParameters > protocols don't exist when the driver starts. > So it's required to set PcdShellLibAutoInitialize to FALSE for > dynamic command drivers. > Update the comments in DEC file to describe such requirement > for this PCD. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jaben Carsey > --- > ShellPkg/ShellPkg.dec | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/ShellPkg/ShellPkg.dec b/ShellPkg/ShellPkg.dec > index 5859c49033..48d50b87b3 100644 > --- a/ShellPkg/ShellPkg.dec > +++ b/ShellPkg/ShellPkg.dec > @@ -81,6 +81,7 @@ [PcdsFeatureFlag] > [PcdsFixedAtBuild] > ## This flag is used to control initialization of the shell library > # This should be FALSE for compiling the shell application itself onl= y. > + # This should be FALSE for compiling the dynamic command drivers. >=20 > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|TRUE|BOOLEAN|0x00 > 000005 >=20 > ## This is the max buffer for ShellLib and internal Shell printings. > -- > 2.15.0.gvfs.1.preview.4