From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3D749222DE120 for ; Thu, 8 Feb 2018 07:08:44 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 07:14:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,479,1511856000"; d="scan'208";a="16224459" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga007.jf.intel.com with ESMTP; 08 Feb 2018 07:14:28 -0800 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Feb 2018 07:14:27 -0800 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.47]) by fmsmsx122.amr.corp.intel.com ([169.254.5.21]) with mapi id 14.03.0319.002; Thu, 8 Feb 2018 07:14:27 -0800 From: "Carsey, Jaben" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , Brijesh Singh , Ard Biesheuvel , "Justen, Jordan L" , Gary Lin Thread-Topic: [edk2] [PATCH v2 0/2] sync some function definitions with their declarations Thread-Index: AQHToGVEZ0kkrMkhNkSR/pM2PNgkRaOani3g Date: Thu, 8 Feb 2018 15:14:26 +0000 Message-ID: References: <20180207224435.10730-1-lersek@redhat.com> In-Reply-To: <20180207224435.10730-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTE1Y2VlNmEtN2FjMi00YjZmLTk2YmUtODliYzA1YjkwODdjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Imd2Vm1RNlU3UTc3N1VnQ0VlU2tNdzViQjZDOHlMWnJVSVlNcU5wcTJCYXM9In0= x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH v2 0/2] sync some function definitions with their declarations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 15:08:44 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, February 07, 2018 2:45 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Brijesh Singh = ; > Ard Biesheuvel ; Justen, Jordan L > ; Gary Lin ; Carsey, Jaben > > Subject: [edk2] [PATCH v2 0/2] sync some function definitions with their > declarations > Importance: High >=20 > Repo: https://github.com/lersek/edk2.git > Branch: sync_defs_to_decls_v2 >=20 > This is version 2 of the series that I posted earlier. Because that > series didn't reach the list at all, due to SMTP issues on my end, I'm > including the v1 blurb here: >=20 > > The patches say it all, just a side remark up here: > > > > These errors would have been caught long ago if we had enabled the > > "-Wmissing-prototypes" gcc option. > > > > (Unfortunately, we can't enable that option even now, because it -- > > laudably -- forces the programmer to give internal linkage ("STATIC") > > to their helper / local functions, and -- as we've learned -- some > > versions of the the Visual Studio debugger choke on STATIC functions. > > Thus, core modules basically never make their internal functions > > STATIC.) >=20 > The v2 changes are noted per patch. >=20 > (This posting should hopefully reach the list; while the original SMTP > issue remains undiagnosed, I attempted to put a work-around in place. > Let's see if it works.) >=20 > Cc: Ard Biesheuvel > Cc: Brijesh Singh > Cc: Gary Lin > Cc: Jaben Carsey > Cc: Jordan Justen > Cc: Ruiyu Ni >=20 > Thanks, > Laszlo >=20 > Laszlo Ersek (2): > ShellPkg/UefiShellDebug1CommandsLib: sync Compress() definition with > decl. > OvmfPkg/PlatformPei: sync AmdSevInitialize() definition with > declaration >=20 > OvmfPkg/PlatformPei/AmdSev.c | 3 ++- > ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.c | 14 > ++++++++------ > ShellPkg/Library/UefiShellDebug1CommandsLib/Compress.h | 1 - > 3 files changed, 10 insertions(+), 8 deletions(-) >=20 > -- > 2.14.1.3.gb7cf6e02401b >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel