Re: [RFC] ShellPkg/Ping: fix loss of first packet

["Carsey, Jaben" <jaben.carsey@intel.com>]

Seems good to me.  I will let Ray review also.

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Meenakshi
> Sent: Friday, February 16, 2018 12:45 AM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; edk2-devel@lists.01.org; lersek@redhat.com
> Subject: [edk2] [RFC] ShellPkg/Ping: fix loss of first packet
> Importance: High
> 
> From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> 
> Issue:
> Reply for first ping packet was getting dropped.
> 
> Cause:
> Sometimes reply message comes even before trasmit
> function returns, hence missing 1st reply
> 
> Fix:
> Prepare the TxList before calling Transmit function.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> ---
>  ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> index bec9535..46ba701 100644
> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ping.c
> @@ -784,14 +784,17 @@ PingSendEchoRequest (
>    }
> 
>    ASSERT(Private->ProtocolPointers.Transmit != NULL);
> +
> +  InsertTailList (&Private->TxList, &TxInfo->Link);
> +
>    Status = Private->ProtocolPointers.Transmit (Private->IpProtocol, TxInfo-
> >Token);
> 
>    if (EFI_ERROR (Status)) {
> +    RemoveEntryList (&TxInfo->Link);
>      PingDestroyTxInfo (TxInfo, Private->IpChoice);
>      return Status;
>    }
> 
> -  InsertTailList (&Private->TxList, &TxInfo->Link);
>    Private->TxCount++;
> 
>    return EFI_SUCCESS;
> --
> 1.9.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel