public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory()
@ 2018-03-03  3:04 Hao Wu
  2018-03-03  7:07 ` Ni, Ruiyu
  2018-03-05 15:12 ` Carsey, Jaben
  0 siblings, 2 replies; 3+ messages in thread
From: Hao Wu @ 2018-03-03  3:04 UTC (permalink / raw)
  To: edk2-devel; +Cc: Hao Wu, Jaben Carsey, Ruiyu Ni

Within function UpdateDisplayFromHistory():

When getting a character with different attribute with the current one,
the statement to compare the character with a 'NULL' char should be:

*StringSegmentEnd != CHAR_NULL

rather than:

StringSegmentEnd != CHAR_NULL

This commit resolves this typo.

Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 ShellPkg/Application/Shell/ConsoleLogger.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Application/Shell/ConsoleLogger.c b/ShellPkg/Application/Shell/ConsoleLogger.c
index bc96da1f1b..074e0cf046 100644
--- a/ShellPkg/Application/Shell/ConsoleLogger.c
+++ b/ShellPkg/Application/Shell/ConsoleLogger.c
@@ -2,7 +2,7 @@
   Provides interface to shell console logger.
 
   (C) Copyright 2013 Hewlett-Packard Development Company, L.P.<BR>
-  Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2016 Hewlett-Packard Development Company, L.P.<BR>
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -322,7 +322,7 @@ UpdateDisplayFromHistory(
         //
         StringSegmentEndChar = CHAR_NULL;
         for ( StringSegmentEnd = StringSegment
-            ; StringSegmentEnd != CHAR_NULL
+            ; *StringSegmentEnd != CHAR_NULL
             ; StringSegmentEnd++
             , Column++
            ){
-- 
2.12.0.windows.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-05 15:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-03  3:04 [PATCH] ShellPkg/ConsoleLogger: Fix a typo in UpdateDisplayFromHistory() Hao Wu
2018-03-03  7:07 ` Ni, Ruiyu
2018-03-05 15:12 ` Carsey, Jaben

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox