ShellPkg: reconnect command resulted in hang

ShellPkg: reconnect command resulted in hang

[Meenakshi Aggarwal]

Hi,


I was trying reconnect shell command with UART handle [20]

20 R - -  0  1   1 VenHw(D3987D4B-971A-435F-8CAF-4967EB627241)/Uart(115200,8,N,1)

Shell> reconnect 20

After this reconnect command, shell didnt come back, looks like a hang.
I analyzed further and see that code has executed completely and reached to shell but console is not coming.


In "reconnect -r" , we are calling ConnectAllConsoles() separately between disconnect and connect calls.

Why is this so?

Why only connect call is nt sufficient to bring the console up?

Please help me in understanding this.


Thanks,
Meenakshi

Re: ShellPkg: reconnect command resulted in hang

[Carsey, Jaben]

Are you using this serial port? Are you connected to the device via this serial port?

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Meenakshi Aggarwal
> Sent: Thursday, March 08, 2018 1:35 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] ShellPkg: reconnect command resulted in hang
> Importance: High
> 
> Hi,
> 
> 
> I was trying reconnect shell command with UART handle [20]
> 
> 20 R - -  0  1   1 VenHw(D3987D4B-971A-435F-8CAF-
> 4967EB627241)/Uart(115200,8,N,1)
> 
> Shell> reconnect 20
> 
> After this reconnect command, shell didnt come back, looks like a hang.
> I analyzed further and see that code has executed completely and reached
> to shell but console is not coming.
> 
> 
> In "reconnect -r" , we are calling ConnectAllConsoles() separately between
> disconnect and connect calls.
> 
> Why is this so?
> 
> Why only connect call is nt sufficient to bring the console up?
> 
> Please help me in understanding this.
> 
> 
> Thanks,
> Meenakshi
> 
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

Re: ShellPkg: reconnect command resulted in hang

[Meenakshi Aggarwal]

Yes, i am connected to the device using this serial port.

> -----Original Message-----
> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> Sent: Thursday, March 08, 2018 8:50 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> devel@lists.01.org
> Subject: RE: ShellPkg: reconnect command resulted in hang
> 
> Are you using this serial port? Are you connected to the device via this serial
> port?
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Meenakshi Aggarwal
> > Sent: Thursday, March 08, 2018 1:35 AM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] ShellPkg: reconnect command resulted in hang
> > Importance: High
> >
> > Hi,
> >
> >
> > I was trying reconnect shell command with UART handle [20]
> >
> > 20 R - -  0  1   1 VenHw(D3987D4B-971A-435F-8CAF-
> > 4967EB627241)/Uart(115200,8,N,1)
> >
> > Shell> reconnect 20
> >
> > After this reconnect command, shell didnt come back, looks like a hang.
> > I analyzed further and see that code has executed completely and reached
> > to shell but console is not coming.
> >
> >
> > In "reconnect -r" , we are calling ConnectAllConsoles() separately between
> > disconnect and connect calls.
> >
> > Why is this so?
> >
> > Why only connect call is nt sufficient to bring the console up?
> >
> > Please help me in understanding this.
> >
> >
> > Thanks,
> > Meenakshi
> >
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C230f90d310a
> 9476a24cc08d585080ef4%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> 7C636561192036205272&sdata=6pvDPfpdDAvpKVB%2BhD7xRov7Rq6x68NhG
> HeL1XRZoFE%3D&reserved=0

Re: ShellPkg: reconnect command resulted in hang

[Carsey, Jaben]

The rest of the drivers needed for console input are not connecting.  

The shell is dependent on the devices in the system table it was initialized with for console functionality.  Only when everything was disconnected does it know to force those to reconnect.  Otherwise you have to get it right yourself.

If you look at the connect command you see the "-c" option to force EFI variable consoles to be reconnected properly.  That doesn't exist in reconnect, but you can get around that with a script file.  You probably want to do something like:

Disconnect 20
Connect 20 -c


-Jaben



> -----Original Message-----
> From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> Sent: Thursday, March 08, 2018 7:27 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; edk2-devel@lists.01.org
> Subject: RE: ShellPkg: reconnect command resulted in hang
> Importance: High
> 
> Yes, i am connected to the device using this serial port.
> 
> > -----Original Message-----
> > From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> > Sent: Thursday, March 08, 2018 8:50 PM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> > devel@lists.01.org
> > Subject: RE: ShellPkg: reconnect command resulted in hang
> >
> > Are you using this serial port? Are you connected to the device via this
> serial
> > port?
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > > Meenakshi Aggarwal
> > > Sent: Thursday, March 08, 2018 1:35 AM
> > > To: edk2-devel@lists.01.org
> > > Subject: [edk2] ShellPkg: reconnect command resulted in hang
> > > Importance: High
> > >
> > > Hi,
> > >
> > >
> > > I was trying reconnect shell command with UART handle [20]
> > >
> > > 20 R - -  0  1   1 VenHw(D3987D4B-971A-435F-8CAF-
> > > 4967EB627241)/Uart(115200,8,N,1)
> > >
> > > Shell> reconnect 20
> > >
> > > After this reconnect command, shell didnt come back, looks like a hang.
> > > I analyzed further and see that code has executed completely and
> reached
> > > to shell but console is not coming.
> > >
> > >
> > > In "reconnect -r" , we are calling ConnectAllConsoles() separately
> between
> > > disconnect and connect calls.
> > >
> > > Why is this so?
> > >
> > > Why only connect call is nt sufficient to bring the console up?
> > >
> > > Please help me in understanding this.
> > >
> > >
> > > Thanks,
> > > Meenakshi
> > >
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > >
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> > s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> >
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C230f90d310a
> >
> 9476a24cc08d585080ef4%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> >
> 7C636561192036205272&sdata=6pvDPfpdDAvpKVB%2BhD7xRov7Rq6x68NhG
> > HeL1XRZoFE%3D&reserved=0

Re: ShellPkg: reconnect command resulted in hang

[Varun Sethi]

Hi Meenakshi,
This seems like the issue we saw while changing the console baud rate. Pankaj had provided a fix for that issue.

Regards
Varun

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Meenakshi Aggarwal
> Sent: Thursday, March 08, 2018 8:57 PM
> To: Carsey, Jaben <jaben.carsey@intel.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] ShellPkg: reconnect command resulted in hang
> 
> Yes, i am connected to the device using this serial port.
> 
> > -----Original Message-----
> > From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> > Sent: Thursday, March 08, 2018 8:50 PM
> > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> > devel@lists.01.org
> > Subject: RE: ShellPkg: reconnect command resulted in hang
> >
> > Are you using this serial port? Are you connected to the device via
> > this serial port?
> >
> > > -----Original Message-----
> > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> > > Of Meenakshi Aggarwal
> > > Sent: Thursday, March 08, 2018 1:35 AM
> > > To: edk2-devel@lists.01.org
> > > Subject: [edk2] ShellPkg: reconnect command resulted in hang
> > > Importance: High
> > >
> > > Hi,
> > >
> > >
> > > I was trying reconnect shell command with UART handle [20]
> > >
> > > 20 R - -  0  1   1 VenHw(D3987D4B-971A-435F-8CAF-
> > > 4967EB627241)/Uart(115200,8,N,1)
> > >
> > > Shell> reconnect 20
> > >
> > > After this reconnect command, shell didnt come back, looks like a hang.
> > > I analyzed further and see that code has executed completely and
> > > reached to shell but console is not coming.
> > >
> > >
> > > In "reconnect -r" , we are calling ConnectAllConsoles() separately
> > > between disconnect and connect calls.
> > >
> > > Why is this so?
> > >
> > > Why only connect call is nt sufficient to bring the console up?
> > >
> > > Please help me in understanding this.
> > >
> > >
> > > Thanks,
> > > Meenakshi
> > >
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > >
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flis
> > t
> > s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> >
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C230f90d310a
> >
> 9476a24cc08d585080ef4%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %
> >
> 7C636561192036205272&sdata=6pvDPfpdDAvpKVB%2BhD7xRov7Rq6x68Nh
> G
> > HeL1XRZoFE%3D&reserved=0
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists
> .01.org%2Fmailman%2Flistinfo%2Fedk2-
> devel&data=02%7C01%7Cv.sethi%40nxp.com%7Ccc1319bae1e94046449f08d
> 585090347%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6365611
> 96147792510&sdata=XuPGfjQ7zKkBKURPwr%2FFiasSvjaCvPU0eC1iA6pQyWY
> %3D&reserved=0

Re: ShellPkg: reconnect command resulted in hang

[Meenakshi Aggarwal]

Thanks Jaben for your reply.

It is helpful information.

Regards,
Meenakshi

> -----Original Message-----
> From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> Sent: Thursday, March 08, 2018 9:07 PM
> To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> devel@lists.01.org
> Subject: RE: ShellPkg: reconnect command resulted in hang
> 
> The rest of the drivers needed for console input are not connecting.
> 
> The shell is dependent on the devices in the system table it was initialized
> with for console functionality.  Only when everything was disconnected does
> it know to force those to reconnect.  Otherwise you have to get it right
> yourself.
> 
> If you look at the connect command you see the "-c" option to force EFI
> variable consoles to be reconnected properly.  That doesn't exist in
> reconnect, but you can get around that with a script file.  You probably want
> to do something like:
> 
> Disconnect 20
> Connect 20 -c
> 
> 
> -Jaben
> 
> 
> 
> > -----Original Message-----
> > From: Meenakshi Aggarwal [mailto:meenakshi.aggarwal@nxp.com]
> > Sent: Thursday, March 08, 2018 7:27 AM
> > To: Carsey, Jaben <jaben.carsey@intel.com>; edk2-devel@lists.01.org
> > Subject: RE: ShellPkg: reconnect command resulted in hang
> > Importance: High
> >
> > Yes, i am connected to the device using this serial port.
> >
> > > -----Original Message-----
> > > From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
> > > Sent: Thursday, March 08, 2018 8:50 PM
> > > To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>; edk2-
> > > devel@lists.01.org
> > > Subject: RE: ShellPkg: reconnect command resulted in hang
> > >
> > > Are you using this serial port? Are you connected to the device via this
> > serial
> > > port?
> > >
> > > > -----Original Message-----
> > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf
> Of
> > > > Meenakshi Aggarwal
> > > > Sent: Thursday, March 08, 2018 1:35 AM
> > > > To: edk2-devel@lists.01.org
> > > > Subject: [edk2] ShellPkg: reconnect command resulted in hang
> > > > Importance: High
> > > >
> > > > Hi,
> > > >
> > > >
> > > > I was trying reconnect shell command with UART handle [20]
> > > >
> > > > 20 R - -  0  1   1 VenHw(D3987D4B-971A-435F-8CAF-
> > > > 4967EB627241)/Uart(115200,8,N,1)
> > > >
> > > > Shell> reconnect 20
> > > >
> > > > After this reconnect command, shell didnt come back, looks like a hang.
> > > > I analyzed further and see that code has executed completely and
> > reached
> > > > to shell but console is not coming.
> > > >
> > > >
> > > > In "reconnect -r" , we are calling ConnectAllConsoles() separately
> > between
> > > > disconnect and connect calls.
> > > >
> > > > Why is this so?
> > > >
> > > > Why only connect call is nt sufficient to bring the console up?
> > > >
> > > > Please help me in understanding this.
> > > >
> > > >
> > > > Thanks,
> > > > Meenakshi
> > > >
> > > >
> > > > _______________________________________________
> > > > edk2-devel mailing list
> > > > edk2-devel@lists.01.org
> > > >
> > >
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> > > s.01.org%2Fmailman%2Flistinfo%2Fedk2-
> > >
> >
> devel&data=02%7C01%7Cmeenakshi.aggarwal%40nxp.com%7C230f90d310a
> > >
> >
> 9476a24cc08d585080ef4%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> > >
> >
> 7C636561192036205272&sdata=6pvDPfpdDAvpKVB%2BhD7xRov7Rq6x68NhG
> > > HeL1XRZoFE%3D&reserved=0