Re: [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue

["Carsey, Jaben" <jaben.carsey@intel.com>]

I have been wondering about that <> thing myself.  Thanks!

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, April 11, 2018 2:02 AM
> To: Feng, YunhuaX <yunhuax.feng@intel.com>; edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: Re: [edk2] [PATCH 1/3] BaseTools: Correct GenSec argument
> dummy free memory issue
> 
> On 04/11/18 09:57, Laszlo Ersek wrote:
> > Hello Yunhua,
> >
> > On 04/10/18 03:09, Feng, YunhuaX wrote:
> >> Free DummyFileBuffer and set DummyFileBuffer to NULL.
> >>
> >> Cc: Liming Gao <liming.gao@intel.com>
> >> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> >> Contributed-under: TianoCore Contribution Agreement 1.1
> >>
> >> Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
> >> ---
> >>  BaseTools/Source/C/GenSec/GenSec.c | 3 ++-
> >>  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > can you please post patch sets with a cover letter, and with shallow
> > threading enabled?
> >
> > The following three commands [1] should configure shallow threading
> > permanently:
> >
> > git config format.coverletter     true
> > git config sendemail.chainreplyto false
> > git config sendemail.thread       true
> 
> A related request: please run the following two commands:
> 
> git config user.name  'Yunhua Feng'
> git config user.email yunhuax.feng@intel.com
> 
> The reason I'm asking for this is that your authorship information is
> currently recorded in git like this (please see commit 6ecab5ad077e):
> 
> Author: Feng, YunhuaX </o=Intel/ou=Exchange Administrative Group
> (FYDIBOHF23SPDLT)/cn=Recipients/cn=Feng, YunhuaX4e1>
> 
> That "thing" in the <> brackets is not an email address.
> 
> I suggest that your authorship information (which is used for new
> commits you create) be identical to the name and email address that you
> use in your Signed-off-by line. The above two git-config commands will
> do that.
> 
> Thanks!
> Laszlo
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel