From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 49D4222742A85 for ; Wed, 11 Apr 2018 07:27:16 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2018 07:27:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,436,1517904000"; d="scan'208";a="49940067" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 11 Apr 2018 07:27:15 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Apr 2018 07:27:15 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.89]) by FMSMSX126.amr.corp.intel.com ([169.254.1.72]) with mapi id 14.03.0319.002; Wed, 11 Apr 2018 07:27:15 -0700 From: "Carsey, Jaben" To: Laszlo Ersek , "Feng, YunhuaX" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue Thread-Index: AdPQaJyWImVAQM6WRpGNOHnp3cmkKwBPNuYAAAI+lgAAA1L4UA== Date: Wed, 11 Apr 2018 14:27:14 +0000 Message-ID: References: <47C64442C08CCD4089DC43B6B5E46BC484BA94@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjA2MWQzOTUtMTc4OC00NmQ2LWE2YWItNzk0YjU2OWZjYTE2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Im5RZHhBSHVYYkVxRVpNK2FIaWZBUldNZTZ2eVJHYjdVTVRpMDhiXC9vMlNZPSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH 1/3] BaseTools: Correct GenSec argument dummy free memory issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 14:27:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have been wondering about that <> thing myself. Thanks! > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, April 11, 2018 2:02 AM > To: Feng, YunhuaX ; edk2-devel@lists.01.org > Cc: Gao, Liming > Subject: Re: [edk2] [PATCH 1/3] BaseTools: Correct GenSec argument > dummy free memory issue >=20 > On 04/11/18 09:57, Laszlo Ersek wrote: > > Hello Yunhua, > > > > On 04/10/18 03:09, Feng, YunhuaX wrote: > >> Free DummyFileBuffer and set DummyFileBuffer to NULL. > >> > >> Cc: Liming Gao > >> Cc: Yonghong Zhu > >> Contributed-under: TianoCore Contribution Agreement 1.1 > >> > >> Signed-off-by: Yunhua Feng > >> --- > >> BaseTools/Source/C/GenSec/GenSec.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > > > > can you please post patch sets with a cover letter, and with shallow > > threading enabled? > > > > The following three commands [1] should configure shallow threading > > permanently: > > > > git config format.coverletter true > > git config sendemail.chainreplyto false > > git config sendemail.thread true >=20 > A related request: please run the following two commands: >=20 > git config user.name 'Yunhua Feng' > git config user.email yunhuax.feng@intel.com >=20 > The reason I'm asking for this is that your authorship information is > currently recorded in git like this (please see commit 6ecab5ad077e): >=20 > Author: Feng, YunhuaX (FYDIBOHF23SPDLT)/cn=3DRecipients/cn=3DFeng, YunhuaX4e1> >=20 > That "thing" in the <> brackets is not an email address. >=20 > I suggest that your authorship information (which is used for new > commits you create) be identical to the name and email address that you > use in your Signed-off-by line. The above two git-config commands will > do that. >=20 > Thanks! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel