From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B757B2035D6C9 for ; Thu, 26 Apr 2018 07:18:38 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2018 07:18:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,330,1520924400"; d="scan'208";a="44804370" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 26 Apr 2018 07:18:37 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 26 Apr 2018 07:18:37 -0700 Received: from fmsmsx101.amr.corp.intel.com ([169.254.1.89]) by fmsmsx156.amr.corp.intel.com ([169.254.13.124]) with mapi id 14.03.0319.002; Thu, 26 Apr 2018 07:18:37 -0700 From: "Carsey, Jaben" To: "Zhu, Yonghong" , "Zhu, Yonghong" , "edk2-devel@lists.01.org" CC: "Feng, YunhuaX" , "Gao, Liming" Thread-Topic: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743 Thread-Index: AQHT3ELf/3y4tdCy8kaFWd7B5R6iGaQTEpUAgAAGjIA= Date: Thu, 26 Apr 2018 14:18:36 +0000 Message-ID: References: <1524625751-10256-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzA0Y2VhYTMtNGI3My00ODQ1LWE3YmEtODUwOTUxYjkwMDdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFBcVwvK25ZK3pIQ056N2VlRXB2anVrK2RvVUh3ZGdxdDBNK1ZpbWlQNTBJPSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Fix one invalid change in 6be94743 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 14:18:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Can you also update the comment to match the code please. I think that the= comment is wrong and your code is correct, but now they are opposite. The= comment says skip (return in context) for no binary files, but the new cod= e will skip for modules with binary files... -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Zhu, Yonghong > Sent: Wednesday, April 25, 2018 11:51 PM > To: Zhu, Yonghong ; edk2-devel@lists.01.org > Cc: Feng, YunhuaX ; Gao, Liming > > Subject: Re: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743 >=20 > Reviewed-by: Yonghong Zhu >=20 > Best Regards, > Zhu Yonghong >=20 >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Yonghong Zhu > Sent: Wednesday, April 25, 2018 11:09 AM > To: edk2-devel@lists.01.org > Cc: Feng, YunhuaX ; Gao, Liming > > Subject: [edk2] [Patch] BaseTools: Fix one invalid change in 6be94743 >=20 > From: Yunhua Feng >=20 > Roll back one change in 6be94743, it was updated incorrect. >=20 > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yunhua Feng > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py > b/BaseTools/Source/Python/AutoGen/AutoGen.py > index 56b5d39..ba83d5a 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -3914,11 +3914,11 @@ class ModuleAutoGen(AutoGen): > # Skip the following code for modules with no source files > if not self.SourceFileList: > return >=20 > # Skip the following code for modules without any binary files > - if not self.BinaryFileList: > + if self.BinaryFileList: > return >=20 > ### TODO: How to handles mixed source and binary modules >=20 > # Find all DynamicEx and PatchableInModule PCDs used by this mod= ule > and dependent libraries > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel