From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 18D432096106C for ; Mon, 7 May 2018 11:10:28 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 May 2018 11:10:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,375,1520924400"; d="scan'208";a="53902467" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 07 May 2018 11:10:28 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.228]) by fmsmsx104.amr.corp.intel.com ([169.254.3.184]) with mapi id 14.03.0319.002; Mon, 7 May 2018 11:10:28 -0700 From: "Carsey, Jaben" To: =?iso-8859-1?Q?Marvin_H=E4user?= , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" Thread-Topic: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone. Thread-Index: AQHT5K7o92gCicGCxUSYAwEfJc4i7aQkk/bg Date: Mon, 7 May 2018 18:10:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWIxNThiNDctZmRkNy00YjdmLWExYTAtYjBhMDlkMDY5MTI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlQ2VnlFTHV5ME5ydUFoTm5TOGxISlpvS3hZemVvNjA2YkYrNlRFNFwvRHpFPSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg/UefiShellLevel2CommandsLib: Support unspecified local Timezone. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 18:10:29 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Marvin H=E4user > Sent: Saturday, May 05, 2018 1:23 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Ni, Ruiyu > Subject: [edk2] [PATCH] ShellPkg/UefiShellLevel2CommandsLib: Support > unspecified local Timezone. > Importance: High >=20 > EFI_RUNTIME_SERVICES.GetTime() might return an unspecified Timezone, > such as when SetTime() has not been called after the PC-AT CMOS RTC > was cut off power. Consider this case by not attempting Timezone > translations for when it is invalid. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marvin Haeuser > --- > ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > index 7d2e15f5206b..73804b4516ba 100644 > --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c > @@ -2,7 +2,7 @@ > Main file for ls shell level 2 function. >=20 > (C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
> - Copyright (c) 2009 - 2017, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the = BSD > License > which accompanies this distribution. The full text of the license may= be > found at > @@ -506,7 +506,7 @@ PrintLsOutput( > // Change the file time to local time. > // > Status =3D gRT->GetTime(&LocalTime, NULL); > - if (!EFI_ERROR (Status)) { > + if (!EFI_ERROR (Status) && (LocalTime.TimeZone !=3D > EFI_UNSPECIFIED_TIMEZONE)) { > if ((Node->Info->CreateTime.TimeZone !=3D > EFI_UNSPECIFIED_TIMEZONE) && > (Node->Info->CreateTime.Month >=3D 1 && Node->Info- > >CreateTime.Month <=3D 12)) { > // > -- > 2.17.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel