From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Zhu, Yonghong" <yonghong.zhu@intel.com>
Subject: Re: [PATCH v1 1/1] BaseTools: incorrect calculation for 16M
Date: Wed, 9 May 2018 20:52:39 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA3CF5AC4@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <474312956cb17ee2f24af7054dbae03922231b90.1525795268.git.jaben.carsey@intel.com>
Ignore. Duplicate. Already sent out.
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jaben Carsey
> Sent: Wednesday, May 09, 2018 1:51 PM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: [edk2] [PATCH v1 1/1] BaseTools: incorrect calculation for 16M
> Importance: High
>
> the "0x" was missing.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>
> ---
> BaseTools/Source/Python/GenFds/FvImageSection.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/GenFds/FvImageSection.py
> b/BaseTools/Source/Python/GenFds/FvImageSection.py
> index eb84b44bbec4..57ecea0377bf 100644
> --- a/BaseTools/Source/Python/GenFds/FvImageSection.py
> +++ b/BaseTools/Source/Python/GenFds/FvImageSection.py
> @@ -1,7 +1,7 @@
> ## @file
> # process FV image section generation
> #
> -# Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the
> BSD License
> @@ -83,7 +83,7 @@ class FvImageSection(FvImageSectionClassObject):
> if MaxFvAlignment >= 0x400:
> if MaxFvAlignment >= 0x100000:
> #The max alignment supported by FFS is 16M.
> - if MaxFvAlignment >=1000000:
> + if MaxFvAlignment >= 0x1000000:
> self.Alignment = "16M"
> else:
> self.Alignment = str(MaxFvAlignment / 0x100000) + "M"
> --
> 2.16.2.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-05-09 20:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1525795268.git.jaben.carsey@intel.com>
2018-05-08 16:01 ` [PATCH v1 1/1] BaseTools: incorrect calculation for 16M Jaben Carsey
2018-05-09 0:57 ` Zhu, Yonghong
[not found] ` <cover.1525899066.git.jaben.carsey@intel.com>
2018-05-09 20:51 ` [PATCH v1 1/1] BaseTools: loop to retry remove when it fails Jaben Carsey
2018-05-09 23:47 ` Kinney, Michael D
2018-05-10 14:15 ` Carsey, Jaben
2018-05-09 20:52 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA3CF5AC4@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox