From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] BaseTools: Enhance error message when file is not exist for Gensec
Date: Mon, 14 May 2018 14:38:22 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA3CF8CC7@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <1526258745-22648-1-git-send-email-yonghong.zhu@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Yonghong Zhu
> Sent: Sunday, May 13, 2018 5:46 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [Patch] BaseTools: Enhance error message when file is not
> exist for Gensec
>
> When the file is not exist in workspace or packages path, current
> Gensec tool doesn't report exactly error message.
>
> FILE FV_IMAGE = 11111111-4CF1-42D8-A0C3-B3F60779dF4D {
> SECTION GUIDED A7717414-C616-4977-9420-844712A735BF {
> SECTION FV_IMAGE = TestPkg/Test.fd
> }
> }
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yonghong Zhu <yonghong.zhu@intel.com>
> ---
> BaseTools/Source/Python/GenFds/FvImageSection.py | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/BaseTools/Source/Python/GenFds/FvImageSection.py
> b/BaseTools/Source/Python/GenFds/FvImageSection.py
> index 57ecea0..3a4d8fb 100644
> --- a/BaseTools/Source/Python/GenFds/FvImageSection.py
> +++ b/BaseTools/Source/Python/GenFds/FvImageSection.py
> @@ -131,10 +131,16 @@ class FvImageSection(FvImageSectionClassObject):
> self.Alignment = str (FvAlignmentValue / 0x400) + "K"
> else:
> # FvAlignmentValue is less than 1K
> self.Alignment = str (FvAlignmentValue)
> FvFileObj.close()
> + else:
> + if len (mws.getPkgPath()) == 0:
> + EdkLogger.error("GenFds", FILE_NOT_FOUND, "%s is not
> found in WORKSPACE: %s" % self.FvFileName,
> GenFdsGlobalVariable.WorkSpaceDir)
> + else:
> + EdkLogger.error("GenFds", FILE_NOT_FOUND, "%s is not
> found in packages path:\n\t%s" % (self.FvFileName,
> '\n\t'.join(mws.getPkgPath())))
> +
> else:
> EdkLogger.error("GenFds", GENFDS_ERROR, "FvImageSection
> Failed! %s NOT found in FDF" % self.FvName)
>
> #
> # Prepare the parameter of GenSection
> --
> 2.6.1.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-05-14 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 0:45 [Patch] BaseTools: Enhance error message when file is not exist for Gensec Yonghong Zhu
2018-05-14 14:38 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA3CF8CC7@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox