From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1E165209603C4 for ; Tue, 15 May 2018 14:55:30 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2018 14:55:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,404,1520924400"; d="scan'208";a="228799527" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 15 May 2018 14:55:29 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 15 May 2018 14:55:29 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.228]) by fmsmsx120.amr.corp.intel.com ([169.254.15.21]) with mapi id 14.03.0319.002; Tue, 15 May 2018 14:55:29 -0700 From: "Carsey, Jaben" To: =?iso-8859-1?Q?Marvin_H=E4user?= , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. Thread-Index: AQHT7IPC73BiwYJ5j0qlJch2fSujo6QxTUvwgAACLLCAAAXr8A== Date: Tue, 15 May 2018 21:55:28 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQxMjU5YWYtODI0OS00YWZkLTkxZjEtZDViNDFlNGNhMmZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNtZmpicmZpd2c2dXdHRFJRalZDY0t6MDdDeUdVY1dETmkrMXVlMUE3ekE9In0= x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 21:55:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable I have no clue on OSS laws/rules, I was just confused. I think that you do= no need to update any copyright (except your own). The code change looks good and that is about all I can really say. :) -Jaben > -----Original Message----- > From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] > Sent: Tuesday, May 15, 2018 2:35 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben > Subject: RE: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. > Importance: High >=20 > Hey Jaben, >=20 > I'm used to keeping the copyright date updated and because both the > specification where the definition originates from and the present header > are published by Intel, this effectively is all Intel IP. > Was this an incorrect change nevertheless? I'm not an expert in OSS > contribution law. >=20 > Thanks, > Marvin >=20 > > -----Original Message----- > > From: Carsey, Jaben > > Sent: Tuesday, May 15, 2018 11:26 PM > > To: Marvin H=E4user > > Subject: RE: [PATCH] MdePkg/Hpet: Add Event Timer Block ID definition. > > > > Marvin, > > > > Non-technical question here, but why do you update intel copyright from= a > > non-intel email address. This seems odd to me... > > > > Thanks > > -Jaben > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf O= f > > > Marvin H=E4user > > > Sent: Tuesday, May 15, 2018 12:35 PM > > > To: edk2-devel@lists.01.org > > > Cc: Kinney, Michael D ; Gao, Liming > > > > > > Subject: [edk2] [PATCH] MdePkg/Hpet: Add Event Timer Block ID > > definition. > > > > > > This patch adds the HPET Event Timer Block ID definition that can be > > > found in the IA-PC HPET Specification, section 3.2.4. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Marvin Haeuser > > > --- > > > MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h | 18 > > > +++++++++++++++++- > > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > > > diff --git > > > a/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > > > b/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > > > index 0d83cd5335de..926445233944 100644 > > > --- a/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > > > +++ > b/MdePkg/Include/IndustryStandard/HighPrecisionEventTimerTable.h > > > @@ -2,7 +2,7 @@ > > > ACPI high precision event timer table definition, at www.intel.com > > > Specification name is IA-PC HPET (High Precision Event Timers) > > > Specification. > > > > > > - Copyright (c) 2007 - 2008, Intel Corporation. All rights > > > reserved.
> > > + Copyright (c) 2007 - 2018, Intel Corporation. All rights > > > + reserved.
> > > This program and the accompanying materials > > > are licensed and made available under the terms and conditions of > > > the BSD License > > > which accompanies this distribution. The full text of the license > > > may be found at @@ -22,6 +22,22 @@ // #pragma pack(1) > > > > > > +/// > > > +/// HPET Event Timer Block ID described in IA-PC HPET Specification, > 3.2.4. > > > +/// > > > +typedef union { > > > + struct { > > > + UINT32 Revision : 8; > > > + UINT32 NumberOfTimers : 5; > > > + UINT32 CounterSize : 1; > > > + UINT32 Reserved : 1; > > > + UINT32 LegacyRoute : 1; > > > + UINT32 VendorId : 16; > > > + } Bits; > > > + UINT32 Uint32; > > > +} EFI_ACPI_HIGH_PRECISION_EVENT_TIMER_BLOCK_ID; > > > + > > > + > > > /// > > > /// High Precision Event Timer Table header definition. > > > /// > > > -- > > > 2.17.0.windows.1 > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel