From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B7A232034860B for ; Tue, 22 May 2018 07:26:10 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2018 07:26:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,430,1520924400"; d="scan'208";a="41950760" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 22 May 2018 07:26:09 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.228]) by FMSMSX105.amr.corp.intel.com ([169.254.4.229]) with mapi id 14.03.0319.002; Tue, 22 May 2018 07:26:09 -0700 From: "Carsey, Jaben" To: "Gao, Liming" , "Marvin.Haeuser@outlook.com" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH v2] BaseTools/Workspace: Fix ValueChain set Thread-Index: AQHT8cLNi6bjJKr2hE+ysdEHYdbib6Q7okxQgAAQbGCAAABhsIAAALQQgAAaG1A= Date: Tue, 22 May 2018 14:26:08 +0000 Message-ID: References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E22ED7C@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E22ED9C@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E22ED9C@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjczNDVjNjMtOTMzYy00NTJiLTlhZTgtYjY5NzM1MDA0ODUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ0tGczRIcWlVYWlHeXZLb0pUYW5FeWlCTndUMml4ZFRUQTBsK05DVGVUclJNeTZTbHlVSmlZT2lVNGtVeUZIVSJ9 x-ctpclassification: CTP_NT x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH v2] BaseTools/Workspace: Fix ValueChain set X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 May 2018 14:26:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Marvin, I have seen funny stuff when outlook shows me the email with patch, but it'= s part of the displaying not the sending bits... -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Gao, Liming > Sent: Tuesday, May 22, 2018 5:52 AM > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain set >=20 > Yes. I also check V1. It also pass patchchecker. >=20 > > -----Original Message----- > > From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] > > Sent: Tuesday, May 22, 2018 8:51 PM > > To: edk2-devel@lists.01.org > > Cc: Gao, Liming ; Zhu, Yonghong > > > Subject: RE: [PATCH v2] BaseTools/Workspace: Fix ValueChain set > > > > Thanks Liming! > > Maybe this is an issue with my e-mail client or server, I just heard Ex= change > sometimes messes up. > > If there really is no such change as I'm observing here, V1 should be f= ine > too. > > > > Regards, > > Marvin. > > > > > -----Original Message----- > > > From: Gao, Liming > > > Sent: Tuesday, May 22, 2018 2:49 PM > > > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > > > Cc: Zhu, Yonghong > > > Subject: RE: [PATCH v2] BaseTools/Workspace: Fix ValueChain set > > > > > > Marvin: > > > I don't see the whitespace in this patch. I also run > > > BaseTools\Scripts\PatchCheck.py. There is no issue found. > > > > > > > -----Original Message----- > > > > From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] > > > > Sent: Tuesday, May 22, 2018 7:52 PM > > > > To: edk2-devel@lists.01.org > > > > Cc: Gao, Liming ; Zhu, Yonghong > > > > > > > > Subject: RE: [PATCH v2] BaseTools/Workspace: Fix ValueChain set > > > > > > > > This is odd. I generated another patch and checked for whitespace a= nd > > > CRLF/LF changes and found everything to be fine. > > > > Now V2 has the exact same whitespace change as V1. Also, if I see i= t > > > > right, it failed to CC Yonghong even though the CMD clearly shows t= he > cc. > > > > > > > > Is there maybe some git expert around who has an idea what the issu= e > > > could be? > > > > > > > > Thanks, > > > > Marvin > > > > > > > > > -----Original Message----- > > > > > From: edk2-devel On Behalf Of > > > > > Marvin H=E4user > > > > > Sent: Tuesday, May 22, 2018 1:48 PM > > > > > To: edk2-devel@lists.01.org > > > > > Cc: liming.gao@intel.com > > > > > Subject: [edk2] [PATCH v2] BaseTools/Workspace: Fix ValueChain se= t > > > > > > > > > > Commit 88252a90d1ca7846731cd2e4e8e860454f7d97a3 changed > > > ValueChain > > > > > from a dict to a set, but also changed the (former) key type from= a > > > > > touple to two separate values, which was probably unintended and > > > > > also breaks build for packages involving Structured PCDs, because > > > > > add() only takes one argument. > > > > > This commit changes the values back to touples. > > > > > > > > > > V2: > > > > > - Removed a whitespace change. > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Marvin Haeuser > > > > > --- > > > > > BaseTools/Source/Python/Workspace/DscBuildData.py | 4 ++-- > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py > > > > > b/BaseTools/Source/Python/Workspace/DscBuildData.py > > > > > index 8476543c5352..0262a91ed855 100644 > > > > > --- a/BaseTools/Source/Python/Workspace/DscBuildData.py > > > > > +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py > > > > > @@ -1347,7 +1347,7 @@ class > DscBuildData(PlatformBuildClassObject): > > > > > nextskuid =3D self.SkuIdMgr.GetNextSkuId= (nextskuid) > > > > > stru_pcd.SkuOverrideValues[skuid] =3D > > > > > copy.deepcopy(stru_pcd.SkuOverrideValues[nextskuid]) if not > > > > > NoDefault else copy.deepcopy({defaultstorename: > > > > > stru_pcd.DefaultValues for defaultstorename in DefaultStores} if > > > > > DefaultStores else > > > > > {TAB_DEFAULT_STORES_DEFAULT:stru_pcd.DefaultValues}) > > > > > if not NoDefault: > > > > > - stru_pcd.ValueChain.add(skuid,'') > > > > > + stru_pcd.ValueChain.add((skuid,'')) > > > > > if stru_pcd.Type in > > > > > [self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_HII], > > > > > self._PCD_TYPE_STRING_[MODEL_PCD_DYNAMIC_EX_HII]]: > > > > > for skuid in SkuIds: > > > > > nextskuid =3D skuid @@ -1366,7 +1366,7 @@ cl= ass > > > > > DscBuildData(PlatformBuildClassObject): > > > > > for defaultstoreid in DefaultStores: > > > > > if defaultstoreid not in > stru_pcd.SkuOverrideValues[skuid]: > > > > > > > > > > stru_pcd.SkuOverrideValues[skuid][defaultstoreid] =3D > > > > > > > > > copy.deepcopy(stru_pcd.SkuOverrideValues[nextskuid][mindefaultstoren > > > > > a > > > > > me]) > > > > > - stru_pcd.ValueChain.add(skuid,defaul= tstoreid) > > > > > + > > > > > + stru_pcd.ValueChain.add((skuid,defaultstoreid)) > > > > > S_pcd_set =3D DscBuildData.OverrideByFdfComm(S_pcd_set) > > > > > Str_Pcd_Values =3D self.GenerateByteArrayValue(S_pcd_set= ) > > > > > if Str_Pcd_Values: > > > > > -- > > > > > 2.17.0.windows.1 > > > > > > > > > > _______________________________________________ > > > > > edk2-devel mailing list > > > > > edk2-devel@lists.01.org > > > > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel