From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B2E8D210D514B for ; Thu, 21 Jun 2018 08:47:00 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2018 08:47:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,252,1526367600"; d="scan'208";a="66538740" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 21 Jun 2018 08:47:00 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.125]) by fmsmsx104.amr.corp.intel.com ([169.254.3.155]) with mapi id 14.03.0319.002; Thu, 21 Jun 2018 08:46:59 -0700 From: "Carsey, Jaben" To: Gary Lin , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [edk2] [PATCH v3 01/20] BaseTools: Fix a typo in ini.py Thread-Index: AQHUCRqJmANsAGTzZEKiU1sPr6ueZaRq27tg Date: Thu, 21 Jun 2018 15:46:58 +0000 Message-ID: References: <20180621044346.28495-1-glin@suse.com> <20180621044346.28495-2-glin@suse.com> In-Reply-To: <20180621044346.28495-2-glin@suse.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTkyMTkyNjctZTIyMy00Y2I5LTlhNDAtYTRjMWE2MTdiNmE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZm92S1RzUEx3Mzd6YjVlSTR0dUpBUHpwOEFyclozMndiSCtuQ0hvVGJ2WWVVam13cU5MRlhZcUV1UHhRdnZibSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH v3 01/20] BaseTools: Fix a typo in ini.py X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 15:47:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey Note: I am not a maintainer of BaseTools and do not push commits for it :) > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Gary Lin > Sent: Wednesday, June 20, 2018 9:43 PM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Gao, Liming > > Subject: [edk2] [PATCH v3 01/20] BaseTools: Fix a typo in ini.py > Importance: High >=20 > "if mis not None:" =3D> "if m is not None:" >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Cc: Jaben Carsey > Cc: Yonghong Zhu > Cc: Liming Gao > Signed-off-by: Gary Lin > --- >=20 > BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel/in > i.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel > /ini.py > b/BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel > /ini.py > index bf1040d6bac4..ea83327052f2 100644 > --- > a/BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel > /ini.py > +++ > b/BaseTools/Scripts/PackageDocumentTools/plugins/EdkPlugins/basemodel > /ini.py > @@ -122,7 +122,7 @@ class BaseINIFile(object): > continue >=20 > m =3D section_re.match(templine) > - if mis not None: # found a section > + if m is not None: # found a section > inGlobal =3D False > # Finish the latest section first > if len(sObjs) !=3D 0: > -- > 2.17.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel