From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 00260202E541E for ; Wed, 11 Jul 2018 10:10:12 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 10:10:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,338,1526367600"; d="scan'208";a="239556902" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 11 Jul 2018 10:10:12 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.106]) by fmsmsx104.amr.corp.intel.com ([169.254.3.114]) with mapi id 14.03.0319.002; Wed, 11 Jul 2018 10:10:11 -0700 From: "Carsey, Jaben" To: Laszlo Ersek , "rbacik@gmail.com" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , Vladimir Olovyannikov , "Justen, Jordan L" , "Gao, Liming" , "Yao, Jiewen" , "Kinney, Michael D" , "Zhang, Chao B" Thread-Topic: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB Thread-Index: AQHUGKCC7NHIgKqjX0GoQtFfEqgt0qSKYxIAgAACvoD//9x8gA== Date: Wed, 11 Jul 2018 17:10:11 +0000 Message-ID: References: <20180710225105.28443-1-roman.bacik@broadcom.com> <5bca3f43-7c23-dca6-03cd-2d647d8fe253@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGQzNTJjN2UtNjE1Zi00NmViLTg0MDMtYmU1MDdmMTMwOGRjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQmgxdzQ4blpoM1BRcWRqbmFEUTl3YktHU0JSTUxXRk1NeUloU3pGdU1lOU5YdmpNZzJkQTdWVjRGcHVLbys2QyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Subject: Re: [PATCH v2] SecurityPkg: Fix assert when setting key from eMMC/SD/USB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 17:10:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Wednesday, July 11, 2018 5:16 AM > To: rbacik@gmail.com; edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Vladimir Olovyannikov > ; Justen, Jordan L > ; Gao, Liming ; Carsey, > Jaben ; Yao, Jiewen ; > Kinney, Michael D ; Zhang, Chao B > > Subject: Re: [edk2] [PATCH v2] SecurityPkg: Fix assert when setting key f= rom > eMMC/SD/USB > Importance: High >=20 > On 07/11/18 14:05, Laszlo Ersek wrote: >=20 > > - The OpenFileByDevicePath() function is duplicated in the following > > modules: "NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c", and > > "MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskFileExplorer.c". > With the > > implication that the alignment issue you found affects all three driver= s! >=20 > Note that I've mutually diffed the three function definitions between > each other (with "diff -b"), and there are only whitespace and comment > wrapping differences. >=20 > So, again, this function looks like a prime suspect for UefiLib. >=20 > I do see the strange reference at the end ("undefined SHELL_FILE_HANDLE > format"); I think that's simply stale, and should be removed. Looks like the stale reference may be from origination as derived from Shel= lOpenFileByDevicePath. I agree this should be moved to a lib. Any way we = could merge the shell's only slightly different version also into the mix? -Jaben >=20 > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel