From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: AlexeiFedorov <Alexei.Fedorov@arm.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ard.Biesheuvel@linaro.org" <Ard.Biesheuvel@linaro.org>,
"Leif.Lindholm@linaro.org" <Leif.Lindholm@linaro.org>,
"Matteo.Carlini@arm.com" <Matteo.Carlini@arm.com>,
"Stephanie.Hughes-Fitt@arm.com" <Stephanie.Hughes-Fitt@arm.com>,
"nd@arm.com" <nd@arm.com>, "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"Evan.Lloyd@arm.com" <Evan.Lloyd@arm.com>,
"Sami.Mujawar@arm.com" <Sami.Mujawar@arm.com>
Subject: Re: [PATCH v2] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors
Date: Fri, 13 Jul 2018 14:46:57 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA40E2E96@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180713110536.30792-2-Alexei.Fedorov@arm.com>
This patch look good, and with this the v1 looks good, but I don't see a single patch that I could apply and push. Can you send out a single patch with all the changes?
-Jaben
> -----Original Message-----
> From: AlexeiFedorov [mailto:Alexei.Fedorov@arm.com]
> Sent: Friday, July 13, 2018 4:06 AM
> To: edk2-devel@lists.01.org
> Cc: Ard.Biesheuvel@linaro.org; Leif.Lindholm@linaro.org;
> Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com; nd@arm.com;
> Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>;
> Evan.Lloyd@arm.com; Sami.Mujawar@arm.com
> Subject: [PATCH v2] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017
> compilation errors
> Importance: High
>
> Please find v2 patch which corrects local variable
> name SigPtr to SignaturePtr.
>
> This patch fixes VS2017 compilation errors for
> UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c
> and
> UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c
> reported in
> https://bugzilla.tianocore.org/show_bug.cgi?id=985
> https://bugzilla.tianocore.org/show_bug.cgi?id=986
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
> ---
> All the changes can be seen at
> https://github.com/AlexeiFedorov/edk2/tree/298_fix_acpiview_v2
>
> Notes:
> v1:
> - GtdtParser.c DumpFTBlock() function:
> change UINT16 type of Length parameter to UINT32
> change UINT16 type of GTBlockTimerLength variable to UINT32
> - XsdtParser.c ParseAcpiXsdt() function:
> change name of local variable Ptr to SignaturePtr
> v2:
> - XsdtParser.c ParseAcpiXsdt() function:
> correct name of local variable SigPtr to SignaturePtr
>
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c
> | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.
> c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.
> c
> index
> 014b6259aa9cfe4093b6f19d4ff0be1e8096fd9b..a5e1412484b56258c40e0cb4d
> 795157ffbce6826 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.
> c
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.
> c
> @@ -105,7 +105,7 @@ ParseAcpiXsdt (
> &Revision
> );
>
> - SigPtr = (UINT8*)Signature;
> + SignaturePtr = (UINT8*)Signature;
>
> UnicodeSPrint (
> Buffer,
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
prev parent reply other threads:[~2018-07-13 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 11:05 [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors AlexeiFedorov
2018-07-13 11:05 ` [PATCH v2] " AlexeiFedorov
2018-07-13 14:46 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA40E2E96@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox