From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B57442098844A for ; Fri, 13 Jul 2018 07:47:25 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2018 07:47:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,347,1526367600"; d="scan'208";a="74551977" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 13 Jul 2018 07:46:59 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 13 Jul 2018 07:46:59 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.106]) by fmsmsx117.amr.corp.intel.com ([169.254.3.3]) with mapi id 14.03.0319.002; Fri, 13 Jul 2018 07:46:58 -0700 From: "Carsey, Jaben" To: AlexeiFedorov , "edk2-devel@lists.01.org" CC: "Ard.Biesheuvel@linaro.org" , "Leif.Lindholm@linaro.org" , "Matteo.Carlini@arm.com" , "Stephanie.Hughes-Fitt@arm.com" , "nd@arm.com" , "Ni, Ruiyu" , "Evan.Lloyd@arm.com" , "Sami.Mujawar@arm.com" Thread-Topic: [PATCH v2] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors Thread-Index: AQHUGpmBKRY4Gya0YkiIz2CAFgOl26SNOyEA Date: Fri, 13 Jul 2018 14:46:57 +0000 Message-ID: References: <20180713110536.30792-1-Alexei.Fedorov@arm.com> <20180713110536.30792-2-Alexei.Fedorov@arm.com> In-Reply-To: <20180713110536.30792-2-Alexei.Fedorov@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzgxNGE4MjEtOTQxNS00YTlmLTg4YmItYzNiNzllZWY1NDhhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicitHd2o2NGFoTTd5UVRSVkFRKytnblNUTUZvbjYySXQ5akVVVU4rVEpoZTVUVlpKVCtQT0R6RVQ2S0haSFk1MyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH v2] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 14:47:26 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch look good, and with this the v1 looks good, but I don't see a si= ngle patch that I could apply and push. Can you send out a single patch wi= th all the changes? -Jaben > -----Original Message----- > From: AlexeiFedorov [mailto:Alexei.Fedorov@arm.com] > Sent: Friday, July 13, 2018 4:06 AM > To: edk2-devel@lists.01.org > Cc: Ard.Biesheuvel@linaro.org; Leif.Lindholm@linaro.org; > Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com; nd@arm.com; > Carsey, Jaben ; Ni, Ruiyu ; > Evan.Lloyd@arm.com; Sami.Mujawar@arm.com > Subject: [PATCH v2] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 > compilation errors > Importance: High >=20 > Please find v2 patch which corrects local variable > name SigPtr to SignaturePtr. >=20 > This patch fixes VS2017 compilation errors for > UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c > and > UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c > reported in > https://bugzilla.tianocore.org/show_bug.cgi?id=3D985 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D986 >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > --- > All the changes can be seen at > https://github.com/AlexeiFedorov/edk2/tree/298_fix_acpiview_v2 >=20 > Notes: > v1: > - GtdtParser.c DumpFTBlock() function: > change UINT16 type of Length parameter to UINT32 > change UINT16 type of GTBlockTimerLength variable to UINT32 > - XsdtParser.c ParseAcpiXsdt() function: > change name of local variable Ptr to SignaturePtr > v2: > - XsdtParser.c ParseAcpiXsdt() function: > correct name of local variable SigPtr to SignaturePtr >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c > | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > index > 014b6259aa9cfe4093b6f19d4ff0be1e8096fd9b..a5e1412484b56258c40e0cb4d > 795157ffbce6826 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > @@ -105,7 +105,7 @@ ParseAcpiXsdt ( > &Revision > ); >=20 > - SigPtr =3D (UINT8*)Signature; > + SignaturePtr =3D (UINT8*)Signature; >=20 > UnicodeSPrint ( > Buffer, > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20