From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 79C63209884C9 for ; Fri, 13 Jul 2018 09:39:11 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2018 09:39:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,348,1526367600"; d="scan'208";a="66745958" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 13 Jul 2018 09:39:10 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 13 Jul 2018 09:39:10 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.106]) by FMSMSX113.amr.corp.intel.com ([169.254.13.25]) with mapi id 14.03.0319.002; Fri, 13 Jul 2018 09:39:10 -0700 From: "Carsey, Jaben" To: AlexeiFedorov , "edk2-devel@lists.01.org" CC: "Ard.Biesheuvel@linaro.org" , "Leif.Lindholm@linaro.org" , "Matteo.Carlini@arm.com" , "Stephanie.Hughes-Fitt@arm.com" , "nd@arm.com" , "Ni, Ruiyu" , "Evan.Lloyd@arm.com" , "Sami.Mujawar@arm.com" , "Dong, Eric" Thread-Topic: [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors Thread-Index: AQHUGryV9sOmKH2VG0WonQ57YxPEF6SNWmfQ Date: Fri, 13 Jul 2018 16:39:09 +0000 Message-ID: References: <20180713151701.20168-1-Alexei.Fedorov@arm.com> In-Reply-To: <20180713151701.20168-1-Alexei.Fedorov@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGZhNzBlNDAtNDRlOS00YThiLWI2ZWEtMWQ3MDJhZWI3MWM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOHlXWVh5ZVRlWXk2Z3pla1ZIUVpRaEkydjIzOFh4OEQzdWlzWmh4VTcxTFRHVm1ONjM2QVcraHl6cWhvUm5LdiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 compilation errors X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 16:39:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey Adding Eric Dong also. > -----Original Message----- > From: AlexeiFedorov [mailto:Alexei.Fedorov@arm.com] > Sent: Friday, July 13, 2018 8:17 AM > To: edk2-devel@lists.01.org > Cc: Ard.Biesheuvel@linaro.org; Leif.Lindholm@linaro.org; > Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com; nd@arm.com; > Carsey, Jaben ; Ni, Ruiyu ; > Evan.Lloyd@arm.com; Sami.Mujawar@arm.com > Subject: [PATCH v1] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2017 > compilation errors > Importance: High >=20 > This patch fixes VS2017 compilation errors for > UefiShellAcpiViewCommandLib\Parsers\Gtdt\GtdtParser.c > and > UefiShellAcpiViewCommandLib\Parsers\Xsdt\XsdtParser.c > reported in > https://bugzilla.tianocore.org/show_bug.cgi?id=3D985 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D986 >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > --- > All the changes can be reviewed at > https://github.com/AlexeiFedorov/edk2/tree/298_acpiview_fix_v1 >=20 > Notes: > v1: > - GtdtParser.c DumpFTBlock() function: > change UINT16 type of Length parameter to UINT32 > change UINT16 type of GTBlockTimerLength variable to UINT32 > - XsdtParser.c ParseAcpiXsdt() function: > change name of local variable from Ptr to SignaturePtr >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 4 ++-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c > | 12 ++++++------ > 2 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > index > 3a3cee948ad8cd35ef3a6e13fec9d44300dbe73f..0ab460b02c9e062ac181e42e7 > e77f875a40c86dc 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > @@ -161,12 +161,12 @@ STATIC > VOID > DumpGTBlock ( > IN UINT8* Ptr, > - IN UINT16 Length > + IN UINT32 Length > ) > { > UINT32 Index; > UINT32 Offset; > - UINT16 GTBlockTimerLength; > + UINT32 GTBlockTimerLength; >=20 > Offset =3D ParseAcpi ( > TRUE, > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > index > 99521cd67a714065c2eb9e4e5ec0f2e21f4c9da9..a5e1412484b56258c40e0cb4d > 795157ffbce6826 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser. > c > @@ -96,7 +96,7 @@ ParseAcpiXsdt ( > CONST UINT8* Revision; >=20 > if ((UINT64*)(UINTN)(*TablePointer) !=3D NULL) { > - UINT8* Ptr; > + UINT8* SignaturePtr; >=20 > ParseAcpiHeader ( > (UINT8*)(UINTN)(*TablePointer), > @@ -105,17 +105,17 @@ ParseAcpiXsdt ( > &Revision > ); >=20 > - Ptr =3D (UINT8*)Signature; > + SignaturePtr =3D (UINT8*)Signature; >=20 > UnicodeSPrint ( > Buffer, > sizeof (Buffer), > L"Entry[%d] - %c%c%c%c", > EntryIndex++, > - Ptr[0], > - Ptr[1], > - Ptr[2], > - Ptr[3] > + SignaturePtr[0], > + SignaturePtr[1], > + SignaturePtr[2], > + SignaturePtr[3] > ); > } else { > UnicodeSPrint ( > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20