From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8F64521B02845 for ; Wed, 18 Jul 2018 14:15:37 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2018 14:15:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,371,1526367600"; d="scan'208";a="56039385" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 18 Jul 2018 14:15:36 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 18 Jul 2018 14:15:36 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.106]) by FMSMSX151.amr.corp.intel.com ([169.254.7.207]) with mapi id 14.03.0319.002; Wed, 18 Jul 2018 14:15:36 -0700 From: "Carsey, Jaben" To: Laszlo Ersek , edk2-devel-01 CC: "Zhang, Chao B" , "Dong, Eric" , "Wu, Jiaxin" , "Yao, Jiewen" , "Gao, Liming" , "Kinney, Michael D" , Roman Bacik , "Ni, Ruiyu" , "Fu, Siyuan" , "Zeng, Star" Thread-Topic: [PATCH 0/6] UefiLib: centralize OpenFileByDevicePath() and fix its bugs Thread-Index: AQHUHtkFYv2foKjFQUKut8KNJ+Ika6SVeeXQ Date: Wed, 18 Jul 2018 21:15:35 +0000 Message-ID: References: <20180718205043.17574-1-lersek@redhat.com> In-Reply-To: <20180718205043.17574-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGU3YTFlNWItNmUzYi00ZmNkLTlkM2EtMThhYzk2OTI2MWY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVWVcLzV4S3VtRmpOU1ZtSXJwYnVSM2Z2TzFBdmduWENzcWhYVEhlUVVPK2dkYmh0ZFNoRnVIdEVPaEd4U0phaWMifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH 0/6] UefiLib: centralize OpenFileByDevicePath() and fix its bugs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 21:15:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey One question (do hold up push). Is there a reason to use the former over th= e latter? I use latter and I see you use the former. ASSERT(EFI_ERROR (Status)); ASSERT_EFI_ERROR (Status); > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, July 18, 2018 1:51 PM > To: edk2-devel-01 > Cc: Zhang, Chao B ; Dong, Eric > ; Carsey, Jaben ; Wu, Jiaxin > ; Yao, Jiewen ; Gao, Liming > ; Kinney, Michael D ; > Roman Bacik ; Ni, Ruiyu > ; Fu, Siyuan ; Zeng, Star > > Subject: [PATCH 0/6] UefiLib: centralize OpenFileByDevicePath() and fix i= ts > bugs > Importance: High >=20 > Repo: https://github.com/lersek/edk2.git > Branch: open_file_by_devpath_tiano_1008 >=20 > This series addresses > . >=20 > In this version of the patch set, EfiOpenFileByDevicePath() is not added > to the FrameworkUefiLib instance. If FrameworkUefiLib actually needs a > definition of the function, I suggest that we add it once everybody > agrees on the implementation. >=20 > Tested with: >=20 > - MdeModulePkg/RamDiskDxe: created a virtual disk from an ISO file, > using the HII form; browsed the disk contents from the UEFI shell. >=20 > - NetworkPkg/TlsAuthConfigDxe: loaded a CA certificate from a file via > the HII form, successfully booted via HTTPSv4. >=20 > - SecurityPkg/SecureBootConfigDxe: enrolled > "MicCorKEKCA2011_2011-06-24.crt", "MicCorUEFCA2011_2011-06-27.crt", > and "MicWinProPCA2011_2011-10-19.crt", using the HII form; verified > Secure Boot with a Fedora guest. >=20 > - ShellPkg/UefiShellLib: couldn't test the "old shell method" code path. > Help with testing would be appreciated. >=20 > Cc: Chao Zhang > Cc: Eric Dong > Cc: Jaben Carsey > Cc: Jiaxin Wu > Cc: Jiewen Yao > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Roman Bacik > Cc: Ruiyu Ni > Cc: Siyuan Fu > Cc: Star Zeng >=20 > Thanks, > Laszlo >=20 > Laszlo Ersek (6): > MdePkg/UefiLib: introduce EfiOpenFileByDevicePath() > MdeModulePkg/RamDiskDxe: replace OpenFileByDevicePath() with UefiLib > API > NetworkPkg/TlsAuthConfigDxe: replace OpenFileByDevicePath() with > UefiLib API > SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with > UefiLib API > ShellPkg/UefiShellLib: drop DeviceHandle param of > ShellOpenFileByDevicePath() > ShellPkg/UefiShellLib: rebase ShellOpenFileByDevicePath() to UefiLib > API >=20 > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > | 1 - > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskFileExplorer.c > | 140 ------------ > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c > | 2 +- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h > | 39 ---- > MdePkg/Include/Library/UefiLib.h = | 86 ++++++++ > MdePkg/Library/UefiLib/UefiLib.c = | 226 > ++++++++++++++++++++ > MdePkg/Library/UefiLib/UefiLib.inf = | 1 + > NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf = | 1 > - > NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c = | 141 > +----------- >=20 > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi > gDxe.inf | 1 - >=20 > SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi > gFileExplorer.c | 151 +------------ > ShellPkg/Include/Library/ShellLib.h = | 2 - > ShellPkg/Library/UefiShellLib/UefiShellLib.c = | 118 +------- > -- > ShellPkg/Library/UefiShellLib/UefiShellLib.inf = | 3 +- > 14 files changed, 321 insertions(+), 591 deletions(-) >=20 > -- > 2.14.1.3.gb7cf6e02401b