From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>, "Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [patch] ShellPkg/Dp: Cumulate the perf data of "DB:Stop"
Date: Thu, 19 Jul 2018 14:56:21 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA40EBEA7@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180719070747.53368-1-dandan.bi@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Thursday, July 19, 2018 12:08 AM
> To: edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [patch] ShellPkg/Dp: Cumulate the perf data of "DB:Stop"
> Importance: High
>
> Currently DP tool will cumulate the performance data for
> Driver Binding Support/Start, will count the number they
> appears, and record the maximum/minimum time value...
> Now add Driver Binding Stop performance data to the
> cumulative data to keep consistency.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> index 213f6057c9..2c094b63c9 100644
> --- a/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> +++ b/ShellPkg/DynamicCommand/DpDynamicCommand/Dp.c
> @@ -71,11 +71,12 @@ UINTN mMeasurementNum = 0;
> /// Items for which to gather cumulative statistics.
> PERF_CUM_DATA CumData[] = {
> PERF_INIT_CUM_DATA (LOAD_IMAGE_TOK),
> PERF_INIT_CUM_DATA (START_IMAGE_TOK),
> PERF_INIT_CUM_DATA (DRIVERBINDING_START_TOK),
> - PERF_INIT_CUM_DATA (DRIVERBINDING_SUPPORT_TOK)
> + PERF_INIT_CUM_DATA (DRIVERBINDING_SUPPORT_TOK),
> + PERF_INIT_CUM_DATA (DRIVERBINDING_STOP_TOK)
> };
>
> /// Number of items for which we are gathering cumulative statistics.
> UINT32 const NumCum = sizeof(CumData) / sizeof(PERF_CUM_DATA);
>
> --
> 2.14.3.windows.1
prev parent reply other threads:[~2018-07-19 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 7:07 [patch] ShellPkg/Dp: Cumulate the perf data of "DB:Stop" Dandan Bi
2018-07-19 14:56 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA40EBEA7@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox