From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
edk2-devel-01 <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution
Date: Tue, 24 Jul 2018 22:25:03 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA40F0E62@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180724132114.31505-1-lersek@redhat.com>
Laszlo,
Do you think that using the incorrect name for a library instance should generate an error? I would have thought it would have...
-Jaben
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, July 24, 2018 6:21 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Subject: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous
> ResourcePublicationLib resolution
>
> The class name for the "PeiResourcePublicationLib" instance is just
> "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no
> module included in the ArmVirtPkg platforms depends on this lib class;
> remove its resolution.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Julien Grall <julien.grall@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Notes:
> built on all six platforms:
>
> ArmVirtQemu-AARCH64
> ArmVirtQemu-ARM
> ArmVirtQemuKernel-AARCH64
> ArmVirtQemuKernel-ARM
> ArmVirtXen-AARCH64
> ArmVirtXen-ARM
>
> ArmVirtPkg/ArmVirt.dsc.inc | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 8bb54c5e6579..70a0ac4d786c 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM]
>
> PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc
> eLib.inf
>
> OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN
> ull/OemHookStatusCodeLibNull.inf
>
> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base
> PeCoffGetEntryPointLib.inf
> -
> PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiR
> esourcePublicationLib.inf
>
> UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco
> mpressLib.inf
>
> ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx
> tractGuidedSectionLib.inf
>
> --
> 2.14.1.3.gb7cf6e02401b
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-07-24 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 13:21 [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution Laszlo Ersek
2018-07-24 13:22 ` Ard Biesheuvel
2018-07-24 20:46 ` Laszlo Ersek
2018-07-24 22:25 ` Carsey, Jaben [this message]
2018-07-25 0:44 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA40F0E62@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox