From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2232621B02845 for ; Tue, 24 Jul 2018 15:25:51 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 15:25:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,399,1526367600"; d="scan'208";a="59188971" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 24 Jul 2018 15:25:20 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.106]) by fmsmsx104.amr.corp.intel.com ([169.254.3.114]) with mapi id 14.03.0319.002; Tue, 24 Jul 2018 15:25:04 -0700 From: "Carsey, Jaben" To: Laszlo Ersek , edk2-devel-01 Thread-Topic: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution Thread-Index: AQHUI1E+W44W0tnFOU2jFuSvUGw2nqSe83nQ Date: Tue, 24 Jul 2018 22:25:03 +0000 Message-ID: References: <20180724132114.31505-1-lersek@redhat.com> In-Reply-To: <20180724132114.31505-1-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGY4MGZmOGQtZjRiZC00NjZhLTliNzMtMzQ4NTkwZTg2NTI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT0ZoK2F5SXNOWm5uTjZZWlg3NlwvOStlcG5mZGM4aFVObm9ZS0lreVRIM1VtSlp0eU5nd3phV0c3Y1RJeU5BcWUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ArmVirtPkg: remove wrong and superfluous ResourcePublicationLib resolution X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 22:25:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, Do you think that using the incorrect name for a library instance should ge= nerate an error? I would have thought it would have... -Jaben > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, July 24, 2018 6:21 AM > To: edk2-devel-01 > Subject: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous > ResourcePublicationLib resolution >=20 > The class name for the "PeiResourcePublicationLib" instance is just > "ResourcePublicationLib", not "PeiResourcePublicationLib". However, no > module included in the ArmVirtPkg platforms depends on this lib class; > remove its resolution. >=20 > Cc: Ard Biesheuvel > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > built on all six platforms: >=20 > ArmVirtQemu-AARCH64 > ArmVirtQemu-ARM > ArmVirtQemuKernel-AARCH64 > ArmVirtQemuKernel-ARM > ArmVirtXen-AARCH64 > ArmVirtXen-ARM >=20 > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > 1 file changed, 1 deletion(-) >=20 > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 8bb54c5e6579..70a0ac4d786c 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM] >=20 > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc > eLib.inf >=20 > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN > ull/OemHookStatusCodeLibNull.inf >=20 > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base > PeCoffGetEntryPointLib.inf > - > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiR > esourcePublicationLib.inf >=20 > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco > mpressLib.inf >=20 > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx > tractGuidedSectionLib.inf >=20 > -- > 2.14.1.3.gb7cf6e02401b >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel