From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0A086210C1EF2 for ; Wed, 25 Jul 2018 08:48:17 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jul 2018 08:48:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,401,1526367600"; d="scan'208";a="59401033" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 25 Jul 2018 08:48:17 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 25 Jul 2018 08:48:16 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.106]) by fmsmsx122.amr.corp.intel.com ([169.254.5.95]) with mapi id 14.03.0319.002; Wed, 25 Jul 2018 08:48:16 -0700 From: "Carsey, Jaben" To: "Gao, Liming" , Laszlo Ersek , edk2-devel-01 Thread-Topic: Library class misname Thread-Index: AdQkLsjBLrSUTtb4Sr2lY5Am7nz+AQ== Date: Wed, 25 Jul 2018 15:48:15 +0000 Message-ID: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGY4MGZmOGQtZjRiZC00NjZhLTliNzMtMzQ4NTkwZTg2NTI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT0ZoK2F5SXNOWm5uTjZZWlg3NlwvOStlcG5mZGM4aFVObm9ZS0lreVRIM1VtSlp0eU5nd3phV0c3Y1RJeU5BcWUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: Library class misname X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Jul 2018 15:48:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Note: I changed the subject as this is not about Laszlo's patch at this poi= nt. Liming, I agree. We definitely need to balance performance and features. I didn't= say we should add it; I assumed it was already there. Was there any side effect of a misnamed library class? Could a module have= used the library with the wrong name? What if there was a library with co= rrect name also included? -Jaben > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, July 24, 2018 5:45 PM > To: Carsey, Jaben ; Laszlo Ersek > ; edk2-devel-01 > Subject: RE: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous > ResourcePublicationLib resolution > Importance: High >=20 > Jaben: > Yes. BaseTools can generate the error message for it. But, more checker= in > BaseTools parser phase will also increase the build performance. This is = the > balance here. >=20 > Thanks > Liming > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Carsey, Jaben > > Sent: Wednesday, July 25, 2018 6:25 AM > > To: Laszlo Ersek ; edk2-devel-01 devel@lists.01.org> > > Subject: Re: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous > ResourcePublicationLib resolution > > > > Laszlo, > > > > Do you think that using the incorrect name for a library instance shoul= d > generate an error? I would have thought it would have... > > > > -Jaben > > > > > -----Original Message----- > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf O= f > > > Laszlo Ersek > > > Sent: Tuesday, July 24, 2018 6:21 AM > > > To: edk2-devel-01 > > > Subject: [edk2] [PATCH] ArmVirtPkg: remove wrong and superfluous > > > ResourcePublicationLib resolution > > > > > > The class name for the "PeiResourcePublicationLib" instance is just > > > "ResourcePublicationLib", not "PeiResourcePublicationLib". However, n= o > > > module included in the ArmVirtPkg platforms depends on this lib class= ; > > > remove its resolution. > > > > > > Cc: Ard Biesheuvel > > > Cc: Julien Grall > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Laszlo Ersek > > > --- > > > > > > Notes: > > > built on all six platforms: > > > > > > ArmVirtQemu-AARCH64 > > > ArmVirtQemu-ARM > > > ArmVirtQemuKernel-AARCH64 > > > ArmVirtQemuKernel-ARM > > > ArmVirtXen-AARCH64 > > > ArmVirtXen-ARM > > > > > > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > > > index 8bb54c5e6579..70a0ac4d786c 100644 > > > --- a/ArmVirtPkg/ArmVirt.dsc.inc > > > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > > > @@ -211,7 +211,6 @@ [LibraryClasses.common.PEIM] > > > > > > > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc > > > eLib.inf > > > > > > > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN > > > ull/OemHookStatusCodeLibNull.inf > > > > > > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/Base > > > PeCoffGetEntryPointLib.inf > > > - > > > > PeiResourcePublicationLib|MdePkg/Library/PeiResourcePublicationLib/PeiR > > > esourcePublicationLib.inf > > > > > > > UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDeco > > > mpressLib.inf > > > > > > > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx > > > tractGuidedSectionLib.inf > > > > > > -- > > > 2.14.1.3.gb7cf6e02401b > > > > > > _______________________________________________ > > > edk2-devel mailing list > > > edk2-devel@lists.01.org > > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel