From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>, "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [patch 3/4] ShellPkg: Remove DxeSmmPerformanceLib
Date: Mon, 30 Jul 2018 17:45:18 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA40F7D63@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180730054504.6480-4-dandan.bi@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Sunday, July 29, 2018 10:45 PM
> To: edk2-devel@lists.01.org
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [patch 3/4] ShellPkg: Remove DxeSmmPerformanceLib
> Importance: High
>
> DxeSmmPerformanceLib previously is used by DP tool.
> But in new pweformance infrastructure, we have updated
> Dp tool to get the performance data from firmware
> performance data table in ACPI.
> So remove the usage of DxeSmmPerformanceLib here.
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> ShellPkg/ShellPkg.dsc | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc
> index cb2a2422ed..59dd07e0ae 100644
> --- a/ShellPkg/ShellPkg.dsc
> +++ b/ShellPkg/ShellPkg.dsc
> @@ -127,15 +127,10 @@
> }
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
>
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> {
> <PcdsFixedAtBuild>
> gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> - <LibraryClasses>
> -
> PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmm
> PerformanceLib.inf
> - }
> - ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf {
> - <LibraryClasses>
> -
> PerformanceLib|MdeModulePkg/Library/DxeSmmPerformanceLib/DxeSmm
> PerformanceLib.inf
> }
> + ShellPkg/DynamicCommand/DpDynamicCommand/DpApp.inf
>
> [BuildOptions]
> *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> --
> 2.14.3.windows.1
next prev parent reply other threads:[~2018-07-30 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 5:45 [patch 0/4] Remove DxeSmmPerformanceLib Dandan Bi
2018-07-30 5:45 ` [patch 1/4] QuarkPlatformPkg: " Dandan Bi
2018-07-30 5:45 ` [patch 2/4] Vlv2TbltDevicePkg: " Dandan Bi
2018-07-30 5:53 ` Wei, David
2018-07-30 5:45 ` [patch 3/4] ShellPkg: " Dandan Bi
2018-07-30 17:45 ` Carsey, Jaben [this message]
2018-07-30 5:45 ` [patch 4/4] MdeModulePkg: " Dandan Bi
2018-08-03 9:31 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA40F7D63@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox