From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>,
"Ni, Ruiyu" <ruiyu.ni@intel.com>
Subject: Re: [patch 1/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure
Date: Mon, 30 Jul 2018 17:46:45 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA40F7DAD@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180730022703.101708-2-dandan.bi@intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Sunday, July 29, 2018 7:27 PM
> To: edk2-devel@lists.01.org
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>; Ni, Ruiyu
> <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [patch 1/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012
> build failure
> Importance: High
>
> Fix following build error:
> xxx\AcpiParser.c(487) : error C2275: 'UINTN' :
> illegal use of this type as an expression
> xxx\ProcessorBind.h(224) : see declaration of 'UINTN'
> xxx\AcpiParser.c(487) : error C2146: syntax error :
> missing ';' before identifier 'OriginalAttribute'
> xxx\AcpiParser.c(487) : error C2065: 'OriginalAttribute' :
> undeclared identifier
> ......
>
> cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> cc: Ruiyu Ni <ruiyu.ni@intel.com>
> cc: Jaben Carsey <jaben.carsey@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> index 6d3bc451ac..630c41b71d 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> @@ -474,19 +474,19 @@ ParseAcpi (
> )
> {
> UINT32 Index;
> UINT32 Offset;
> BOOLEAN HighLight;
> + UINTN OriginalAttribute;
>
> Offset = 0;
>
> // Increment the Indent
> gIndent += Indent;
>
> if (Trace && (AsciiName != NULL)){
> HighLight = GetColourHighlighting ();
> - UINTN OriginalAttribute;
>
> if (HighLight) {
> OriginalAttribute = gST->ConOut->Mode->Attribute;
> gST->ConOut->SetAttribute (
> gST->ConOut,
> --
> 2.14.3.windows.1
next prev parent reply other threads:[~2018-07-30 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 2:26 [patch 0/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix build issues Dandan Bi
2018-07-30 2:27 ` [patch 1/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure Dandan Bi
2018-07-30 17:46 ` Carsey, Jaben [this message]
2018-07-30 2:27 ` [patch 2/4] " Dandan Bi
2018-07-30 17:46 ` Carsey, Jaben
2018-07-30 2:27 ` [patch 3/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS " Dandan Bi
2018-07-30 8:27 ` Alexei Fedorov
2018-07-30 8:49 ` Bi, Dandan
2018-07-30 2:27 ` [patch 4/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix GCC " Dandan Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA40F7DAD@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox