From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DB76D210C4DA9 for ; Mon, 30 Jul 2018 10:46:46 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jul 2018 10:46:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,422,1526367600"; d="scan'208";a="61005354" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 30 Jul 2018 10:46:46 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.106]) by fmsmsx107.amr.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0319.002; Mon, 30 Jul 2018 10:46:46 -0700 From: "Carsey, Jaben" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: Alexei Fedorov , "Ni, Ruiyu" Thread-Topic: [patch 1/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure Thread-Index: AQHUJ6zfopWXhtgdEU2JpMZ/NG5dmKSoCzOg Date: Mon, 30 Jul 2018 17:46:45 +0000 Message-ID: References: <20180730022703.101708-1-dandan.bi@intel.com> <20180730022703.101708-2-dandan.bi@intel.com> In-Reply-To: <20180730022703.101708-2-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzM2Y2Q4NzItYjU1My00OGExLWI2ZGEtZDQ4OTU0MDAyNjljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMzBEWWFESVZpSlJcL0VZK3VwN3BBODRiMEwrVEp5VUJjYndqa0xOdktIUWNqWnBsRGdqYkJJZktYQTVMUnY3TWcifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [patch 1/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 17:46:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Bi, Dandan > Sent: Sunday, July 29, 2018 7:27 PM > To: edk2-devel@lists.01.org > Cc: Alexei Fedorov ; Ni, Ruiyu > ; Carsey, Jaben > Subject: [patch 1/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS2012 > build failure > Importance: High >=20 > Fix following build error: > xxx\AcpiParser.c(487) : error C2275: 'UINTN' : > illegal use of this type as an expression > xxx\ProcessorBind.h(224) : see declaration of 'UINTN' > xxx\AcpiParser.c(487) : error C2146: syntax error : > missing ';' before identifier 'OriginalAttribute' > xxx\AcpiParser.c(487) : error C2065: 'OriginalAttribute' : > undeclared identifier > ...... >=20 > cc: Alexei Fedorov > cc: Ruiyu Ni > cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > index 6d3bc451ac..630c41b71d 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > @@ -474,19 +474,19 @@ ParseAcpi ( > ) > { > UINT32 Index; > UINT32 Offset; > BOOLEAN HighLight; > + UINTN OriginalAttribute; >=20 > Offset =3D 0; >=20 > // Increment the Indent > gIndent +=3D Indent; >=20 > if (Trace && (AsciiName !=3D NULL)){ > HighLight =3D GetColourHighlighting (); > - UINTN OriginalAttribute; >=20 > if (HighLight) { > OriginalAttribute =3D gST->ConOut->Mode->Attribute; > gST->ConOut->SetAttribute ( > gST->ConOut, > -- > 2.14.3.windows.1