public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 0/2] Fix two bugs regarding shell redirection
Date: Thu, 9 Aug 2018 15:38:00 +0000	[thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA4112829@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <20180809034502.131768-1-ruiyu.ni@intel.com>

Both look good.
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Wednesday, August 08, 2018 8:45 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/2] Fix two bugs regarding shell redirection
> Importance: High
> 
> Ruiyu Ni (2):
>   ShellPkg/redirection: Insert \xFEFF after converting ASCII to Unicode
>   ShellPkg/redirection: Insert \xFEFF for ENV variable redirection
> 
>  ShellPkg/Application/Shell/FileHandleWrappers.c | 80
> ++++++++++++++++++-------
>  1 file changed, 58 insertions(+), 22 deletions(-)
> 
> --
> 2.16.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      parent reply	other threads:[~2018-08-09 15:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-09  3:45 [PATCH 0/2] Fix two bugs regarding shell redirection Ruiyu Ni
2018-08-09  3:45 ` [PATCH 1/2] ShellPkg/redirection: Insert \xFEFF after converting ASCII to Unicode Ruiyu Ni
2018-08-09  3:45 ` [PATCH 2/2] ShellPkg/redirection: Insert \xFEFF for ENV variable redirection Ruiyu Ni
2018-08-09 15:38 ` Carsey, Jaben [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB6E33457884FA40993F35157061515CA4112829@FMSMSX103.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox