From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: "Zhu, Yonghong" <yonghong.zhu@intel.com>,
"Feng, YunhuaX" <yunhuax.feng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH V2] BaseTools: Fix regression issue by b23414f6540d
Date: Tue, 21 Aug 2018 16:09:57 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515CA4121FA7@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <B9726D6DCCFB8B4CA276A9169B02216D520EB1F4@SHSMSX103.ccr.corp.intel.com>
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: Zhu, Yonghong
> Sent: Monday, August 20, 2018 10:33 PM
> To: Feng, YunhuaX <yunhuax.feng@intel.com>; edk2-devel@lists.01.org
> Cc: Gao, Liming <liming.gao@intel.com>; Carsey, Jaben
> <jaben.carsey@intel.com>; Zhu, Yonghong <yonghong.zhu@intel.com>
> Subject: RE: [PATCH V2] BaseTools: Fix regression issue by b23414f6540d
> Importance: High
>
> Reviewed-by: Yonghong Zhu <yonghong.zhu@intel.com>
>
> Best Regards,
> Zhu Yonghong
>
>
> -----Original Message-----
> From: Feng, YunhuaX
> Sent: Tuesday, August 21, 2018 8:49 AM
> To: edk2-devel@lists.01.org
> Cc: Zhu, Yonghong <yonghong.zhu@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH V2] BaseTools: Fix regression issue by b23414f6540d
>
> V2: Renaming function DepexExpressionTokenList to DepexExpressionDict
> instead of changing the callers
>
> Fix regression issue by b23414f6540d4f336b6f00b44681911d469f9a04
> AttributeError: 'ModuleAutoGen' object has no attribute
> 'DepexExpressionDict'
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Yonghong Zhu <yonghong.zhu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Yunhua Feng <yunhuax.feng@intel.com>
> ---
> BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py
> b/BaseTools/Source/Python/AutoGen/AutoGen.py
> index 3b1ddc74e8..d30a9be6ee 100644
> --- a/BaseTools/Source/Python/AutoGen/AutoGen.py
> +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py
> @@ -2899,11 +2899,11 @@ class ModuleAutoGen(AutoGen):
> ## Merge dependency expression
> #
> # @retval list The token list of the dependency expression after
> parsed
> #
> @cached_property
> - def DepexExpressionTokenList(self):
> + def DepexExpressionDict(self):
> if self.DxsFile or self.IsLibrary or TAB_DEPENDENCY_EXPRESSION_FILE in
> self.FileTypes:
> return {}
>
> RetVal = {self.ModuleType:''}
>
> --
> 2.12.2.windows.2
prev parent reply other threads:[~2018-08-21 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 0:48 [PATCH V2] BaseTools: Fix regression issue by b23414f6540d Feng, YunhuaX
2018-08-21 5:33 ` Zhu, Yonghong
2018-08-21 16:09 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515CA4121FA7@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox