From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D0D5A210EE4E7 for ; Tue, 21 Aug 2018 09:09:59 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2018 09:09:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,270,1531810800"; d="scan'208";a="74544308" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 21 Aug 2018 09:09:58 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.126]) by FMSMSX108.amr.corp.intel.com ([169.254.9.232]) with mapi id 14.03.0319.002; Tue, 21 Aug 2018 09:09:58 -0700 From: "Carsey, Jaben" To: "Zhu, Yonghong" , "Feng, YunhuaX" , "edk2-devel@lists.01.org" CC: "Gao, Liming" Thread-Topic: [PATCH V2] BaseTools: Fix regression issue by b23414f6540d Thread-Index: AdQ452qcmipZihtrSjqSQZ/uO2FuegAKPNdgABZB50A= Date: Tue, 21 Aug 2018 16:09:57 +0000 Message-ID: References: <47C64442C08CCD4089DC43B6B5E46BC48BAD36@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWVlMWE4Y2UtM2ZlMS00M2U5LWFmYWEtYjAyYWRkNzIzNDExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiejJMaFdUNTlvSldOQVVJNXlwRUU5QncrVTFlSG5RMm1EMjBSQzJ3NXU0S1FYQXdMVnFJNjN3NXQ0bWV2eU9ydyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [PATCH V2] BaseTools: Fix regression issue by b23414f6540d X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 16:10:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Zhu, Yonghong > Sent: Monday, August 20, 2018 10:33 PM > To: Feng, YunhuaX ; edk2-devel@lists.01.org > Cc: Gao, Liming ; Carsey, Jaben > ; Zhu, Yonghong > Subject: RE: [PATCH V2] BaseTools: Fix regression issue by b23414f6540d > Importance: High >=20 > Reviewed-by: Yonghong Zhu >=20 > Best Regards, > Zhu Yonghong >=20 >=20 > -----Original Message----- > From: Feng, YunhuaX > Sent: Tuesday, August 21, 2018 8:49 AM > To: edk2-devel@lists.01.org > Cc: Zhu, Yonghong ; Gao, Liming > ; Carsey, Jaben > Subject: [PATCH V2] BaseTools: Fix regression issue by b23414f6540d >=20 > V2: Renaming function DepexExpressionTokenList to DepexExpressionDict > instead of changing the callers >=20 > Fix regression issue by b23414f6540d4f336b6f00b44681911d469f9a04 > AttributeError: 'ModuleAutoGen' object has no attribute > 'DepexExpressionDict' >=20 > Cc: Liming Gao > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yunhua Feng > --- > BaseTools/Source/Python/AutoGen/AutoGen.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Source/Python/AutoGen/AutoGen.py > b/BaseTools/Source/Python/AutoGen/AutoGen.py > index 3b1ddc74e8..d30a9be6ee 100644 > --- a/BaseTools/Source/Python/AutoGen/AutoGen.py > +++ b/BaseTools/Source/Python/AutoGen/AutoGen.py > @@ -2899,11 +2899,11 @@ class ModuleAutoGen(AutoGen): > ## Merge dependency expression > # > # @retval list The token list of the dependency expression = after > parsed > # > @cached_property > - def DepexExpressionTokenList(self): > + def DepexExpressionDict(self): > if self.DxsFile or self.IsLibrary or TAB_DEPENDENCY_EXPRESSION_F= ILE in > self.FileTypes: > return {} >=20 > RetVal =3D {self.ModuleType:''} >=20 > -- > 2.12.2.windows.2