From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=jaben.carsey@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 92F8D210F2022 for ; Tue, 28 Aug 2018 07:55:54 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2018 07:55:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,299,1531810800"; d="scan'208";a="252582914" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 28 Aug 2018 07:55:30 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 28 Aug 2018 07:55:30 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.126]) by fmsmsx101.amr.corp.intel.com ([169.254.1.66]) with mapi id 14.03.0319.002; Tue, 28 Aug 2018 07:55:29 -0700 From: "Carsey, Jaben" To: "Fu, Siyuan" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Ye, Ting" , "Wu, Jiaxin" Thread-Topic: [edk2] [Patch 2/2] ShellPkg: Update Ifconfig command to accept 32bit subnet mask. Thread-Index: AQHUPnHn59RBiLdpmUCSqvYdANVj+aTVQVow Date: Tue, 28 Aug 2018 14:55:29 +0000 Message-ID: References: <20180828015235.60368-1-siyuan.fu@intel.com> <20180828015235.60368-3-siyuan.fu@intel.com> In-Reply-To: <20180828015235.60368-3-siyuan.fu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWE4ZmE3OWEtNzhhZi00NzIzLWIzMTMtY2EwMzAwMThmNmMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicXhhQkFlNm1JeWRkakZFVk16MURkUVFpeVM2bzdVQXVyME5EcithZGp2aGJXUUZYVjRFU01Hb2FzdjQyaW1aQyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.107] MIME-Version: 1.0 Subject: Re: [Patch 2/2] ShellPkg: Update Ifconfig command to accept 32bit subnet mask. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Aug 2018 14:55:54 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable looks good to me. Ray? Reviewed-by: Jaben Carsey > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu > Siyuan > Sent: Monday, August 27, 2018 6:53 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Ye, Ting ; Wu, Jia= xin > > Subject: [edk2] [Patch 2/2] ShellPkg: Update Ifconfig command to accept > 32bit subnet mask. > Importance: High >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Fu Siyuan > Cc: Ruiyu Ni > Cc: Ye Ting > Cc: Wu Jiaxin > --- > ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c > index 52415e0ad0..e9f644c739 100644 > --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c > +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c > @@ -1032,6 +1032,7 @@ IfConfigSetInterfaceInfo ( > SubnetMask =3D NTOHL (SubnetMask); > TempGateway =3D NTOHL (TempGateway); > if ((SubnetMask !=3D 0) && > + (SubnetMask !=3D 0xFFFFFFFFu) && > !NetIp4IsUnicast (TempGateway, SubnetMask)) { > ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN > (STR_IFCONFIG_INVALID_GATEWAY), gShellNetwork1HiiHandle, VarArg- > >Arg); > ShellStatus =3D SHELL_INVALID_PARAMETER; > -- > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel